[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 02/13] xen/arm: Introduce CONFIG_MMU Kconfig option
- To: Julien Grall <julien@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Mon, 21 Aug 2023 08:45:43 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BxS0xvry7hUaSbAyNLF2l5TwkUBYgSTilfARSSiU95Q=; b=WpPVVm1/2NTs6ucgxsQK9Zzn2xpzZU+IKhN8o8yDqhrg0Ss2aJiPZHOgxPQgbkVS5u9F9aoeRPAV7xO+kySgQ0vcENkbDE+z8CgIajbOaTW0ptQZGkcGXC+v5B0uMAJlGOacTTwP6QwAbm5OBlL5n7u5Xc/jSoaAZPv9ODIa8XcN5TdnYd1mKzgE0by1G5WtXwR3gbULKp8mo6z7z+XLpzyPrHFDVh9N9hd6ndqVLXfrNLOfrYnN+kQvEPsrDG2vPlqCKpkkkW5v67w9VKl5lAlxuPtdw2Lr65NsAGx6y8fSSYJ/+U02sAKJbmeovyNB9xEeDxOemACG3OZdSsRZiA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RLbdVzaqsTXAe3QDU9Gew//cpdB8vLS3kX2ZMtjwNfr3fNauwSZFTtR0dB6u5DvW7zOhqFJaLrFP+W+WdwYDqNTlryF3MIfYcsrSVMYYCw5AUufVe5tsDFlJf0GHbxPhGqLJeLKBS1rEtiUsH9bBLy7zhtuw9UtCxEnt7mF2jFS6CFvufw3bCyp5Winn//s35/IDT+PH3weGSE69e4glwB6bL5/IGLBYA7EvLPEvwGd9nOlycgXAWvfWBCetloZHvXox0/xCg1rHguodIpBAhM7PoV7oxP4eeXrmbwuRhm+6PHvs29aL6KL0xKk9tmlCrI5wqGRovwC3CtgNF0Q7Ew==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>
- Delivery-date: Mon, 21 Aug 2023 08:46:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZzmd4NwPJsprWs0O6+0xd1gAzE6/0ekEAgAAAoAA=
- Thread-topic: [PATCH v5 02/13] xen/arm: Introduce CONFIG_MMU Kconfig option
Hi Julien,
> On Aug 21, 2023, at 16:43, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Henry,
>
> On 14/08/2023 05:25, Henry Wang wrote:
>> There are two types of memory system architectures available for
>> Arm-based systems, namely the Virtual Memory System Architecture (VMSA)
>> and the Protected Memory System Architecture (PMSA). According to
>> ARM DDI 0487G.a, A VMSA provides a Memory Management Unit (MMU) that
>> controls address translation, access permissions, and memory attribute
>> determination and checking, for memory accesses made by the PE. And
>> refer to ARM DDI 0600A.c, the PMSA supports a unified memory protection
>> scheme where an Memory Protection Unit (MPU) manages instruction and
>> data access. Currently, Xen only suuports VMSA.
>
> Typo: s/suuports/supports/
Oops, sorry about this, will fix in v6.
>
>> Introduce a Kconfig option CONFIG_MMU, which is currently default
>> set to y and unselectable because currently only VMSA is supported.
>
> NIT: It would be worth to explicit mention that this will be used in
> follow-up patches. So one will wonder what's the goal of introducing an
> unused config.
>
> Or it could have been merged in the first patch splitting the MMU code so we
> don't introduce a config without any use.
Sure, I will think about this and fix in v6.
>
>> Suggested-by: Julien Grall <jgrall@xxxxxxxxxx>
>> Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>
>
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
Thanks!
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
