[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 3/3] drivers/video: make declarations of defined functions available
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 17 Aug 2023 17:02:21 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I+L34wGYUn1nLC40IHC53VdZ4a8mANwKT0u5/K9e6bk=; b=dklcCyiKvdA0U1pE/h6G620cqRTxBwsh7cd3rZVxC2XrySHK1tLJ3Imxosnde0L4BMCK08zyUnESDhSPYuEJpi4FUD2en9CpB1xqCundbSVHFDVZYeFFQV81chQ8aivX2HxdWCKbUL6FJ09XoLW2iBzD2kF7As7qAXGDWRZrugVhWuNuZGpM59X7VOfnh6D8VlRFNWRaNy4HqUE0sUZJooFh8YKlGXvw2juMhNsm8T2ZCtxDDao+8tyCle2GGIHjrUFFO6rrn0AbqEnhVIHe1CjDAzicuedOs1amNWQmndUqvGYhylZ1eSK1hEW+iCyJLLm3dRKfoHva33WlmGGBZg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LMvci4SrAvhVRIRF6qG9gODxzGwvPLZGW2/Os1K+/8YAK3z4zmNcvDzXXRuBEX2k6flRnJ/SGIbCrg2u0qevKTNFhJnqpwsAXPmnSd5oc+80ibXN04eWlcMVDjpeWy7vs2gnPYnWyLwhiubwNf2hq18TDlcmBi8ifZSKfW0bhrDJ9+hM2nQShQle+S5zmRLJX9fpShWiLmbJptSxuv6abYZnVFC7GGGtF41AQb0aQOIxhFw+enXhGyeP1pn4KIonMQo5Smtx3YBevuKmPQ9pxMC8lcnNpbNITql8DRQ/tSEam2/PdP2J30dzAutIyO53YCA9m/Ov0OoNAUdclshubg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 17 Aug 2023 15:02:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.08.2023 16:52, Nicola Vetrini wrote:
> On 17/08/2023 15:28, Jan Beulich wrote:
>> On 17.08.2023 14:39, Nicola Vetrini wrote:
>>> --- a/xen/include/xen/vga.h
>>> +++ b/xen/include/xen/vga.h
>>> @@ -15,4 +15,20 @@
>>> extern struct xen_vga_console_info vga_console_info;
>>> #endif
>>>
>>> +int fill_console_start_info(struct dom0_vga_console_info *);
>>> +
>>> +#ifdef CONFIG_X86
>>> +void vesa_early_init(void);
>>> +void vesa_endboot(bool_t keep);
>>> +#else
>>> +#define vesa_early_init() ((void)0)
>>> +#define vesa_endboot(x) ((void)0)
>>> +#endif
>>> +
>>> +#ifdef CONFIG_VIDEO
>>> +void vesa_init(void);
>>> +#else
>>> +static inline void vesa_init(void) {};
>>> +#endif
>>
>> Hmm, on one hand you simply move existing code here. But then why don't
>> you leverage the existing #ifdef? The more that it's more specific and
>> in line with drivers/video/Makefile having
>>
>> obj-$(CONFIG_VGA) := vga.o
>>
>> and
>>
>> obj-$(CONFIG_VGA) += vesa.o
>
> Are you saying that CONFIG_VGA implies CONFIG_VIDEO and therefore
> "#ifdef CONFIG_VGA"
> at line 14 of vga.h can be used instead of the #ifdefs inherited from
> the original locations
> to wrap all the declarations that are being moved?
Yes - see drivers/video/Kconfig.
Jan
|
