[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] IOMMU/x86: fix build with old gcc after IO-APIC RTE changes
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 16 Aug 2023 17:40:55 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6FS2bbKXyDp42lV0RI7bXU1c7JdM1KgxAv1nTGVl/wU=; b=TTjdie5Z6+pGYTkunxbg8yB/eH2Y6WbCMXkBymE++z5ubgetefNOAPqhBS4o3U+F4mQ1PTrP6G1fqOAUn/zzR9wLiY6+R7p8W/7chmQ4fP4wzX4QPraSHS2gcgpt/Z+LhbmXab0gT3fGRbONhdhjfqfFIiN5rSVThpc1eIHu2yBdeMQrj4U60uEh9UhysPOO4zrm9WsoatETnRml42cPW18+3ZNpaDQ5Mn9L9Y8KOjNypcq5s/hwpZX4PTD7iRCKnILIhOMV0ij6vQBUc6vao0KriYmuFHso8GgFJjOjVZOCH1JaG14fhroj8Oahv2jpj51sY+7Pb6qn2BMZEKCmFQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Coy9L3xvnh0Pb0HHEQW1w/aR7O+MiY7CPS9ZRhoufeTpbg/n9rgjISPK/zoBXGiNGsYJcL7Zfa4mqkDNo/qTXgIvL4ckOAGgJcBgRYcW0a4RmvotY65R9gfoihK66XovuukHUuTO7jR10nJ9U7Ftb+nrYLPHnl50SrZb2iQ4dZxOL/fTB7seTAB7NjD3UfMdUWUp0FlbsPy++0pmFYdC4idejaZMNvEmuw3avBe/HgcZZ0JVZ7Yq0brnv04qKS9codRKJ6AYqbq+Fjj3S9d4pnlKEQLVDkiMe+F7a50NHjVRnSoLtmnaWCtN+q7aQcDHdY+5oCcNaQI6EJ7dLs/kuA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Kevin Tian <kevin.tian@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 16 Aug 2023 16:41:31 +0000
- Ironport-data: A9a23:Wr0OP6MOEjUDTqDvrR2SlsFynXyQoLVcMsEvi/4bfWQNrUol1TQFn WYaDWHTPavcY2Cgco0kbti29h8P65DTz4BnGQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGjxSs/vrRC9H5qyo42tI5wJmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0rZ8Cm5J9 fUBEmAMUSyY3Oaa65W2bMA506zPLOGzVG8ekldJ6GiASNoDH9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PVxujeMpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eWxHKmBdtOReDQGvhCu2OD6UojVDkqEny2juWFjm/nfdsYN BlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWWRGyc8PGIrDq0ESkTMWIGIyQDSGM4D8LLpYgyilfDS4hlGavs19ntQ2ivn HaNsTQ0gKgVgYgTzaKn8FvbgjWq4J/UUgoy4QaRVWWghu9kWLOYi0WTwQCzxZ59wEyxFzFtY FBsdxCi0d0z
- Ironport-hdrordr: A9a23:TtftwKHnphHs4UXCpLqE5seALOsnbusQ8zAXPiFKJSC9F/byqy nAppsmPHPP5gr5OktBpTnwAsi9qBrnnPYejLX5Vo3SPzUO1lHYSb1K3M/PxCDhBj271sM179 YFT0GmMqyTMWRH
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16/08/2023 10:51 am, Jan Beulich wrote:
> Old gcc won't cope with initializers involving unnamed struct/union
> fields.
>
> Fixes: 3e033172b025 ("x86/iommu: pass full IO-APIC RTE for remapping table
> update")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, although
> --- a/xen/drivers/passthrough/vtd/intremap.c
> +++ b/xen/drivers/passthrough/vtd/intremap.c
> @@ -432,8 +432,7 @@ unsigned int cf_check io_apic_read_remap
> void cf_check io_apic_write_remap_rte(
> unsigned int apic, unsigned int pin, uint64_t rte)
> {
> - struct IO_xAPIC_route_entry new_rte = { .raw = rte };
> - struct IO_xAPIC_route_entry old_rte = { };
> + struct IO_xAPIC_route_entry old_rte = { }, new_rte;
Any chance we can make this = {} while at it?
~Andrew
|
