[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch
- To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Wed, 16 Aug 2023 01:27:58 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7NL2aG1q3F3x9xcOyZD8o/B+s2DhSAUNDUgEjnxCSkQ=; b=ByPeHPnJOy1Z20c7rDgRNqzVxgpu29ig5i9A/dQ/2B6FNaExF8AsXsvMZlorYKGaH4WaBRAgRtDfhbeMh4x8tkxt/WgzOtx127e91/RHwgsr+SIg3puYveNncOC4m3F2oDVwiseGRG3VOKqmVJ9nGm+NsIOwxghlKwJUp18TMXd0g9QfnwWOzypUB+ri4jZJHo03istCvuTcV3p0vsnk1I1t/3eZ3BgKAOiFXwkzUJFsCoglSJPrbVvoNXUDSpAZpwj57xTU8frA8LHwfklHoDmvJ3q082DirKjLorouRhD3nuqcGbzx4Z6fVpMMA7FUrQAOHI4RhQNEVbnoAua9tw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ffxuhvZXdAesr6DRSQpEU0NJ8f0VbA3BxvSNlbtGLTVLBejALWNeIyCm8vOBNE+F3l6fD7Lh9s/LyZi8niZ2D3bYUFUG2S2mjtNGJ3EyF44zc9tFvqbI2Z9PRArKvdckN+SAQy90c325RNmTFRyfqPjWcBQSpo7Z5DnGTGNYtC/VklwDXsmgThFF4EtRNLUyxWEZL/xKiHJH6YmLGrLfB8Wdgj1Px+4tqjjVruRTLPB71jv3sd4gQRB3PU9H2kdrNoml8vTB00BYZs8RnVKfSUoTTQ/TDEcbjXrmiskCL+7/JjPBm4KyA+QC1hn7nmNzmNuxzHgGUubz0CZmfJFF7Q==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Delivery-date: Wed, 16 Aug 2023 01:29:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZxfe0sdxLBCk0m0eqfbJm59//E6/ZhneQgAdlrQCAC0mnAA==
- Thread-topic: [PATCH v2 2/2] fdt: make fdt handling reusable across arch
Hi Daniel,
> On Aug 9, 2023, at 05:05, Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
> wrote:
>
> On 8/4/23 00:10, Henry Wang wrote:
>> Hi Daniel,
>
> Hey Henry!
>
>>> -----Original Message-----
>>> Subject: [PATCH v2 2/2] fdt: make fdt handling reusable across arch
>>>
>>> This refactors reusable code from Arm's bootfdt.c and device-tree.h that is
>>> general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is
>>> introduced for when the ability of parsing DTB files is needed by a
>>> capability
>>> such as hyperlaunch.
>>>
>>> Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
>> As said yesterday, I tested this patch and can confirm this patch will not
>> break any of the boards we used for our testing. So
>> Tested-by: Henry Wang <Henry.Wang@xxxxxxx>
>
> Thank your for running it through your tests.
My pleasure.
>
>> (But I saw there are some comments from Michal and Luca about this
>> patch so I think these comments need to be addressed)
>
> So far the changes are style and a few mechanical. While unlikely to cause a
> functional change that could break, probably best to hold off adding your Tb
> for now.
Sorry for the late response, this email somehow fall through the cracks…
I am ok to retain my T-by tag as the comments are only about styles and
mechanical
changes.
Kind regards,
Henry
>
> v/r
> dps
>
|
