[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [EXT] Re: [PATCH v1 net] page_pool: Cap queue size to 32k.
- To: Jesper Dangaard Brouer <hawk@xxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>
- From: Ratheesh Kannoth <rkannoth@xxxxxxxxxxx>
- Date: Mon, 14 Aug 2023 08:55:14 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pKlbzCrY1DtBhUGV1M+DO81GolN0fk0rkI9WgvE6w74=; b=JfejF8wIyOlLVvzz3JYixBaVKCVBDmLM5W7mwwcVGxCrZcGAVbI4CLhmamy1KHljPqgL2M/wG4H14D4G51vNmjWYx4/yNq2DtcHSQ+T/g1YU6y7q52Z+EZnDwEjRlIxNVEDTuTBFevSKsdD9Rj16Y8yXgGwL9cKw7XogRZplbfpYvTQbj01/wMAWiKvGHucuyLIZQnpyAeO7cpV/pJm4BysfbcJ7wcbk7RPPgDPVdpqLktWQodPltG1ympFoEBD+NOwB/vKSTlqN0fqxhQLFITKYdVTB6qFhG8StD5xMGiNB2w6Z7F/01pbUa0v6f7ogDoQLYwOdRnuTHggJyLzFRg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bkAZ+W/lcO2EAbCs+P1+p0m2cT6KHZyIW9nZUfVtZj/yaS9kX9fSSriJKG/5O/QOcVUMf2bvp3SbKWdDKsqeXozU3PVl+IfSV8M97QmAtTrGW6SHpoNM4B8c17OkUp7+yvNpY2Z0XXTwGgOu8eha4AEwLW9cYQQgm53GOwaEgPRNENBpvkE1+NydQ//wGFXSaogGO1jyBAyphFRsPVRZZE0M2dEtBs7tyZmNK37WZr92CMAzQi6u/jmIAKCook2OxirPB06tMDUA4HcAi/Eu/Nj9BwwD3FPS9A7HXHIu3zY4RItWtE9v798pRFGlhSAx8rvAry+L7LHKy7p/o+g/9A==
- Cc: "davem@xxxxxxxxxxxxx" <davem@xxxxxxxxxxxxx>, "edumazet@xxxxxxxxxx" <edumazet@xxxxxxxxxx>, "kuba@xxxxxxxxxx" <kuba@xxxxxxxxxx>, "pabeni@xxxxxxxxxx" <pabeni@xxxxxxxxxx>, "ast@xxxxxxxxxx" <ast@xxxxxxxxxx>, "daniel@xxxxxxxxxxxxx" <daniel@xxxxxxxxxxxxx>, "john.fastabend@xxxxxxxxx" <john.fastabend@xxxxxxxxx>, "jiawenwu@xxxxxxxxxxxxxx" <jiawenwu@xxxxxxxxxxxxxx>, "mengyuanlou@xxxxxxxxxxxxx" <mengyuanlou@xxxxxxxxxxxxx>, "yang.lee@xxxxxxxxxxxxxxxxx" <yang.lee@xxxxxxxxxxxxxxxxx>, "error27@xxxxxxxxx" <error27@xxxxxxxxx>, "linyunsheng@xxxxxxxxxx" <linyunsheng@xxxxxxxxxx>, "linux-hyperv@xxxxxxxxxxxxxxx" <linux-hyperv@xxxxxxxxxxxxxxx>, "kys@xxxxxxxxxxxxx" <kys@xxxxxxxxxxxxx>, "haiyangz@xxxxxxxxxxxxx" <haiyangz@xxxxxxxxxxxxx>, "wei.liu@xxxxxxxxxx" <wei.liu@xxxxxxxxxx>, "decui@xxxxxxxxxxxxx" <decui@xxxxxxxxxxxxx>, "longli@xxxxxxxxxxxxx" <longli@xxxxxxxxxxxxx>, "shradhagupta@xxxxxxxxxxxxxxxxxxx" <shradhagupta@xxxxxxxxxxxxxxxxxxx>, "linux-hwmon@xxxxxxxxxxxxxxx" <linux-hwmon@xxxxxxxxxxxxxxx>, "michael.chan@xxxxxxxxxxxx" <michael.chan@xxxxxxxxxxxx>, "richardcochran@xxxxxxxxx" <richardcochran@xxxxxxxxx>, "jdelvare@xxxxxxxx" <jdelvare@xxxxxxxx>, "linux@xxxxxxxxxxxx" <linux@xxxxxxxxxxxx>, "salil.mehta@xxxxxxxxxx" <salil.mehta@xxxxxxxxxx>, "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, "linux-mediatek@xxxxxxxxxxxxxxxxxxx" <linux-mediatek@xxxxxxxxxxxxxxxxxxx>, "nbd@xxxxxxxx" <nbd@xxxxxxxx>, "john@xxxxxxxxxxx" <john@xxxxxxxxxxx>, "sean.wang@xxxxxxxxxxxx" <sean.wang@xxxxxxxxxxxx>, "Mark-MC.Lee@xxxxxxxxxxxx" <Mark-MC.Lee@xxxxxxxxxxxx>, "lorenzo@xxxxxxxxxx" <lorenzo@xxxxxxxxxx>, "matthias.bgg@xxxxxxxxx" <matthias.bgg@xxxxxxxxx>, "angelogioacchino.delregno@xxxxxxxxxxxxx" <angelogioacchino.delregno@xxxxxxxxxxxxx>, "linux@xxxxxxxxxxxxxxx" <linux@xxxxxxxxxxxxxxx>, "linux-rdma@xxxxxxxxxxxxxxx" <linux-rdma@xxxxxxxxxxxxxxx>, "saeedm@xxxxxxxxxx" <saeedm@xxxxxxxxxx>, "leon@xxxxxxxxxx" <leon@xxxxxxxxxx>, "gerhard@xxxxxxxxxxxxxxxxxxxxx" <gerhard@xxxxxxxxxxxxxxxxxxxxx>, "maciej.fijalkowski@xxxxxxxxx" <maciej.fijalkowski@xxxxxxxxx>, "alexanderduyck@xxxxxx" <alexanderduyck@xxxxxx>, "wei.fang@xxxxxxx" <wei.fang@xxxxxxx>, "shenwei.wang@xxxxxxx" <shenwei.wang@xxxxxxx>, "xiaoning.wang@xxxxxxx" <xiaoning.wang@xxxxxxx>, "linux-imx@xxxxxxx" <linux-imx@xxxxxxx>, "yisen.zhuang@xxxxxxxxxx" <yisen.zhuang@xxxxxxxxxx>, "lgirdwood@xxxxxxxxx" <lgirdwood@xxxxxxxxx>, "broonie@xxxxxxxxxx" <broonie@xxxxxxxxxx>, "jaswinder.singh@xxxxxxxxxx" <jaswinder.singh@xxxxxxxxxx>, "ilias.apalodimas@xxxxxxxxxx" <ilias.apalodimas@xxxxxxxxxx>, "UNGLinuxDriver@xxxxxxxxxxxxx" <UNGLinuxDriver@xxxxxxxxxxxxx>, "horatiu.vultur@xxxxxxxxxxxxx" <horatiu.vultur@xxxxxxxxxxxxx>, "linux-omap@xxxxxxxxxxxxxxx" <linux-omap@xxxxxxxxxxxxxxx>, "grygorii.strashko@xxxxxx" <grygorii.strashko@xxxxxx>, "simon.horman@xxxxxxxxxxxx" <simon.horman@xxxxxxxxxxxx>, "vladimir.oltean@xxxxxxx" <vladimir.oltean@xxxxxxx>, "aleksander.lobakin@xxxxxxxxx" <aleksander.lobakin@xxxxxxxxx>, "linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx" <linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>, "alexandre.torgue@xxxxxxxxxxx" <alexandre.torgue@xxxxxxxxxxx>, "joabreu@xxxxxxxxxxxx" <joabreu@xxxxxxxxxxxx>, "mcoquelin.stm32@xxxxxxxxx" <mcoquelin.stm32@xxxxxxxxx>, "p.zabel@xxxxxxxxxxxxxx" <p.zabel@xxxxxxxxxxxxxx>, "thomas.petazzoni@xxxxxxxxxxx" <thomas.petazzoni@xxxxxxxxxxx>, "mw@xxxxxxxxxxxx" <mw@xxxxxxxxxxxx>, Sunil Kovvuri Goutham <sgoutham@xxxxxxxxxxx>, Geethasowjanya Akula <gakula@xxxxxxxxxxx>, Subbaraya Sundeep Bhatta <sbhatta@xxxxxxxxxxx>, Hariprasad Kelam <hkelam@xxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "jgross@xxxxxxxx" <jgross@xxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "oleksandr_tyshchenko@xxxxxxxx" <oleksandr_tyshchenko@xxxxxxxx>, "linux-wireless@xxxxxxxxxxxxxxx" <linux-wireless@xxxxxxxxxxxxxxx>, "ryder.lee@xxxxxxxxxxxx" <ryder.lee@xxxxxxxxxxxx>, "shayne.chen@xxxxxxxxxxxx" <shayne.chen@xxxxxxxxxxxx>, "kvalo@xxxxxxxxxx" <kvalo@xxxxxxxxxx>, "andrii@xxxxxxxxxx" <andrii@xxxxxxxxxx>, "martin.lau@xxxxxxxxx" <martin.lau@xxxxxxxxx>, "song@xxxxxxxxxx" <song@xxxxxxxxxx>, "yonghong.song@xxxxxxxxx" <yonghong.song@xxxxxxxxx>, "kpsingh@xxxxxxxxxx" <kpsingh@xxxxxxxxxx>, "sdf@xxxxxxxxxx" <sdf@xxxxxxxxxx>, "haoluo@xxxxxxxxxx" <haoluo@xxxxxxxxxx>, "jolsa@xxxxxxxxxx" <jolsa@xxxxxxxxxx>
- Delivery-date: Mon, 14 Aug 2023 08:56:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZznU+ZcDNaqRkgEScX+JwHjZ6da/pbFAAgAAB4aCAAAxOAIAAARQQ
- Thread-topic: [EXT] Re: [PATCH v1 net] page_pool: Cap queue size to 32k.
> From: Jesper Dangaard Brouer <hawk@xxxxxxxxxx>
> Subject: Re: [EXT] Re: [PATCH v1 net] page_pool: Cap queue size to 32k.
> I agree with Johannes, this commit message is too thin.
ACK.
> It makes sense to give a summary of the discussion, because it show us
> (page_pool maintainers) what you concluded for the discussion.
Got it. Thanks.
> Further more, you also send another patch:
> - "[PATCH net-next] page_pool: Set page pool size"
Okay.
> -
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__lore.kernel.org_all_20230809021920.913324-2D1-2Drkannoth-
> 40marvell.com_&d=DwICaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=aekcsyBCH00
> _LewrEDcQBzsRw8KCpUR0vZb_auTHk4M&m=uvV_vt_cNyQItTD90jF1LdKovP
> 7j7FYtnr7I38__nYY6wHtFHSozYoRSSvCI14nh&s=vGgt2ccGdiRTEhj3MoGVx-
> EXHmB03v6I3UIIY1fEb24&e=
>
> That patch solves the issue for your driver marvell/octeontx2 and I like than
> change.
Okay.
> Why did you conclude that PP core should also change?
I could not answer Jacub's question at
https://lore.kernel.org/netdev/20230810024422.1781312-1-rkannoth@xxxxxxxxxxx/T/
> (p.s. Cc/To list have gotten excessive with 89 recipients)
I added maintainters of all files which used page_pool_init().
|
