[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 6/6] drivers/video: make declarations of defined functions available
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 14 Aug 2023 10:12:29 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i+lz7iz1mLjgFVXCKycP+9u0HBGICLNhuwosAPgaU5g=; b=aLry7Yfpu8y+Bfgs5MVKRQnvhLHqZnmVF1PWs2pnb/4OHEJINjOEef6nl9WH9Oi4G1OjjBaNlRFMoGYMHt6YwgQQCDQP82e3i+5uouxBFpOIA3cAocoIkvyphgwWaBrq1JjvmrkgIRaRyQfy8ILdG6C1WYgo2eI7zXtst82ijC0WXSdb8rJJRaMRyqE/A9l3/CJjbwnq+dqgrKfyRwQdU6WQg7gb4r3sS+3LMttMtcZkgkMPYOAfpAge3ucIiW4/w+U4LEGNbsUPkNbxmx+e23LSEkGwUmkMd/VH8+CPRn+WBtNIpWdhM9ywq7b2Ijb/tm1DWRLPzQPZqInEIRhNOw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R0HUthNGrPKj/0sv9V5I941dR4dNaDMbqqtGj7mOSEyG+n7e28Vyk+y0GvRseg0zVYJDqkNVJ0GwUMwshgAXGxLB767lqysG49k25E6PWbAzPjaAxBEItOT5eR7XspgRteVruPTi63mHjzrCEiPT2bvyFIrMvnbB54HAJ8dshcsqxe7Kr/yaTZCUwOb0sAwduIUbSWkNdhcDX/wyzlotLs1mxFpQFR4e/TtlsZ4hBQwabcd7kjJ9mjeUxC92Jt8fkNvhUPQj/xLxyBdqfuoLlCAMJwg1XtsC5vueubJSIuFJj7fBuDjC9cWed1j/9AyK9c0dbRoLeqAqns+K5lrFLA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 14 Aug 2023 08:13:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.08.2023 09:56, Nicola Vetrini wrote:
> On 14/08/2023 09:47, Jan Beulich wrote:
>> On 11.08.2023 09:19, Nicola Vetrini wrote:
>>> --- a/xen/drivers/video/vga.c
>>> +++ b/xen/drivers/video/vga.c
>>> @@ -9,6 +9,7 @@
>>> #include <xen/mm.h>
>>> #include <xen/param.h>
>>> #include <xen/vga.h>
>>> +#include <xen/console.h>
>>
>> xen/vga.h, which you move the declarations to, is already included
>> here.
>> Why the need for xen/console.h?
>
> vga.c needs a declaration for fill_console_start_info, which is declared
> in console.h, as
> stated in the commit message (it could be clarified perhaps).
Ah, I see. It's not very fortunate mixing of two separate adjustments.
But then I'm inclined to ask: When fill_console_start_info() is
defined in vga.c, wouldn't it make sense to move its declaration to
vga.h? The more considering the type of its parameter?
Jan
|
