[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 5/6] vpic/msix: make 'get_slot' static
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 14 Aug 2023 09:44:31 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NF3yDXWHWAGHT+GvF2W+LhwfIbkiLWgnI7p4uqY9icM=; b=ISecvMVQnDVa1idd+CuCuHdmbEqreDU5mpNRTtrt3+HZsux45s7as65BhI5IaIXF3hEH2ri0SltIgufZ6+7isvCIaITXskc7yq+WnJIOe0ce91gGrekAoa6aklsI9fwi/9e5Z2HTnVP5BYEl8GcD/rl+2Lbw8TIYS55ZiJrt8o/DoYQfqWK1p/ATZ7JmauWUBgXMUBud8AU+NolhPXdcEPec27vOkh5npGpwDsjHVPOwhZTLNt6aaNQLg/Xfi2DbmYM/wD4vFgib2Q1H6gQxGmskeA+J9NowQjVB7XlW8e9Sj0WKkeWtfwY4cyAeLGdBKDM8/P+p8I1CZtxooHP1zw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hP7a7PMmwPvTQEGM/4IUciC3KKw32E0jmQlLybJM7juoI+RklEnqneBICtAXH+b0CnvlKKbPKMxk1JV+/oZZsmH7n4kbbhYlgO8smgKszoy2QXISWt1i2L2ny9UGE4f5LPQ2uPY6+c8XCgNBIMnUMJXdptREHG9FlPbzdu0RPRB+G3vHb1fkHwGB1+FJ6237l2HcmIRSFgYFWtV6UooKGL27uXyvCEt4svrz3gUyGugfs+oh3RDpGcO7tBuXOgf80JpZ8RKMj5WRfVE5HGQINNGt+qaETDSdjvf+dhZrqoSu02/4iuuK9vl+RxGF46CHA4fTKNyobp6EpM4JXwTpNA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 14 Aug 2023 07:44:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11.08.2023 09:19, Nicola Vetrini wrote:
> The function can become static since it's used only within this file.
> This also resolves a violation of MISRA C:2012 Rule 8.4 due to the absence
> of a declaration before the function definition.
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> Fixes: b177892d2d0e ("vpci/msix: handle accesses adjacent to the MSI-X table")
Nit (typo): In the title you mean "vpci/msix", just like this quoted
commit has it. This is important-ish because we also have "vpic"
elsewhere in the tree. (Can certainly be adjusted while committing.)
Jan
|
