Re: [PATCH 1/2] xen/arm: Fix initrd placeholders generation in make_chosen_node()

[Julien Grall <julien@xxxxxxx>]

Hi Michal,

On 10/08/2023 12:25, Michal Orzel wrote:
> When booting a dom0less domU without initial ramdisk, it was observed
> that Xen still creates empty linux,initrd-{start,end} properties under
> /chosen node. This is because in make_chosen_node(), generation of initrd
> placeholders (later on filled with the real values) is protected with
> a check for presence of kernel bootmodule (always present) instead of
> initrd bootmodule. Fix it along with renaming the variable from "mod" to
> "initrd" to prevent similar mistakes in the future.
>
> Fixes: 48f4bf6bdeb4 ("arm/acpi: Create min DT stub for Dom0")
(No change required, just a remark about the tag)

Someone wanting to backport this would need to be cautious. The fix 
would not apply as-is for Xen older than ~4.11 because 'mod' is used to 
fetch the command line as well.
This also means that it would not be correct to simply replace 'mod' 
with 'initrd'. Anyway, for upstream, this would only be backported up to 
4.17 as the other release are either only security supported or not 
supported at all. So this is not a concern for us.
Cheers,

--
Julien Grall