Re: [PATCH 2/5] xen/arm: Add asm/domain.h include to kernel.h

[Julien Grall <julien@xxxxxxx>]

Hi Luca,

On 08/08/2023 09:00, Luca Fancellu wrote:
> Add asm/domain.h that is defining the type 'enum domain_type', it
> is needed on arm64 build where this type is used for a member of
> the structure kernel_info.
I read "needed" as in it Xen build is broken. But AFAIK, this is more a 
latent issue if someone else want to include the header. Is that correct?
If so, how about:

The 'enum domain_type' is defined by 'asm/domain.h' which is not 
included (directly or indirectly) by 'asm/kernel.h'.
This currently doesn't break the compilation because asm/domain.h will 
included by the user of 'kernel.h'. But it would be better to avoid 
relying on it. So add the include in 'asm/domain.h'.
> Fixes: 66e994a5e74f ("xen: arm64: add guest type to domain field.")
While we aim to have header self-contained, this has never been a 
guarantee in Xen. So I would argue this is not a fix in the sense it 
someone would want to ingest it in there tree.
Cheers,

> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> ---
>   xen/arch/arm/include/asm/kernel.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/xen/arch/arm/include/asm/kernel.h 
> b/xen/arch/arm/include/asm/kernel.h
> index 4617cdc83bac..0a23e86c2d37 100644
> --- a/xen/arch/arm/include/asm/kernel.h
> +++ b/xen/arch/arm/include/asm/kernel.h
> @@ -7,6 +7,7 @@
>   #define __ARCH_ARM_KERNEL_H__
>   
>   #include <xen/device_tree.h>
> +#include <asm/domain.h>
>   #include <asm/setup.h>
>   
>   /*
--
Julien Grall