[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] xen/arm: Fix initrd placeholders generation in make_chosen_node()
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Thu, 10 Aug 2023 13:31:09 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JOxKVzseZD3tX21APUomyo7znpD9dTbWKiHyQZa8zOE=; b=TExzh8xf6+GDYRY/ONvXUcIvnnyJ8DPI4ry5OJiWFbbHbikwB1dATlmkYLMUnjEtEGlbEr6X7BRQgITYKhErf9GPwolBqX79OmVtMw1wZ22WUGNK3Ktrp4+iD8tUHCdVFZ29uNX3AE1Ydk2wsve/JqatjaY0HDXMZKCYS4PWzf6VkiZx6etxLM/6vIeC74EXxTgsY/GTic2jiRNLkp0O2KCrETLvKZrVHTYJRp+2aoXG+Caboh8SaucvQleIYRBZnDlD3sBAq3Rg5MQI2mBHKgucmEOOx7FV7gw77CGhf8m3LVSQjyQ6wzS5ze+JhloHJ8JoNsv7mY133sRCd1qqtA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ol0rNu1CRltDLnqFUhTx3PDKYsnRLeuA3UQzTZHu4jzCsF1NdG9jJMFvh3DgycrcqT208kVZFVxvTFDcMzSChIZu/EL7RaFmbSn+sp1AdFjK+8wm2w7N1tGSLb2wpGQ8Ak4j2z3pUJmW/NZq5u/oevmbIB1fXIjLyszzfvbus0b+sKKapAnM641xGhqamnQRre2mE3tTwIX3vpATG7d11wYInBJ2GwHSLO8Dgq5gQyONzz49UmiAfqeAX7fSRL59SbgJXCzi5UFnLXLxxan7IwZyIYBlc0AaqrxyymfM+bHflfvq8P6uNpDSMMx/ZKLCb+Uq2SQY0tbOw7gXg+8WpQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 10 Aug 2023 13:31:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZy32D8bvJWFq2S02jfFulAD0k7K/jhs8A
- Thread-topic: [PATCH 1/2] xen/arm: Fix initrd placeholders generation in make_chosen_node()
> On 10 Aug 2023, at 12:25, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> When booting a dom0less domU without initial ramdisk, it was observed
> that Xen still creates empty linux,initrd-{start,end} properties under
> /chosen node. This is because in make_chosen_node(), generation of initrd
> placeholders (later on filled with the real values) is protected with
> a check for presence of kernel bootmodule (always present) instead of
> initrd bootmodule. Fix it along with renaming the variable from "mod" to
> "initrd" to prevent similar mistakes in the future.
>
> Fixes: 48f4bf6bdeb4 ("arm/acpi: Create min DT stub for Dom0")
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
Hi Michal, good catch!
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Cheers,
Luca
|
