[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 05/13] xen/arm: Move MMU related definitions from config.h to mmu/layout.h
- To: Julien Grall <julien@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Thu, 10 Aug 2023 07:41:36 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HSmEdoGbXnWJoTpB5+MVGMuOF+COnyl27ANio2UNZn0=; b=isEH6kaHxp4fywSBXuONQufM7E5dibgbkylAaldMNx/s6sVDB5e8VJnXTGmqX+t5stJoggkm4tEQbb3hW90j/Kgn9iEhMFqln+1IORneaPw7pkG2DGOAWoRKekbjND6vTQJncVbpUgAeyKEFJb9+GXAiL0phdVUO3rwwo76XcWgFhy1yTSRXD1/3ZhAPNQUicdMbTN8sYTCCRHJnPfP0iBLRNKqbJzXxhARiBY341nMZW8xV66fsYT0MIF7SSKUS002BS2x2JiKJHhQFdaKWRYQJLMVXMyl8yoEvskcybjVsCQvvpnyIj7mhR4T1huYczmA9TEHrFlK0CvNHC+l/Ig==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mVWib2Zwdwu/3jC8EzdAw4b5Jdg+kE94A3w0VIPeS2P1x0pFmuUHKzKfHDCx5C8hM8xVB4qj7aqYCaXA6zLqsDGhKi37cZTyPiqKXhbDq0U35t/MeoiMklgRpEsIl1/Hsvn5PVZNBmwxrYoF2kSMjQLeLqpnuPoZmt6oVOXT+NF7ZEU7RAD4EzBKqCQ7tlnXrzwGOShWm+vQU2CDC1IzCsqc1x85TssM/E+rkOpTiiWtOtuhKTiQKyf1a58y/AymvM0vLOLUHxWJx1pPt9Iei1+WHQDB7yiy2BlyV0yqA3cl8l04iQ2ZoDxiKFFp5Hp07JhJ/MX03V7UbYF0aHZh1A==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>
- Delivery-date: Thu, 10 Aug 2023 07:42:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZxCqMQIVv2nNAnUKuY4URBAgkmK/h7woAgAFEwoA=
- Thread-topic: [PATCH v4 05/13] xen/arm: Move MMU related definitions from config.h to mmu/layout.h
Hi Julien,
> On Aug 9, 2023, at 20:19, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Henry,
>
> On 01/08/2023 04:44, Henry Wang wrote:
>> From: Wei Chen <wei.chen@xxxxxxx>
>> Xen defines some global configuration macros for Arm in config.h.
>> However there are some address layout related definitions that are
>> defined for MMU systems only, and these definitions could not be
>> used by MPU systems. Adding ifdefs with CONFIG_HAS_MPU to gate these
>
> You haven't yet introduced HAS_MPU. So I would suggest to write: 'Adding
> ifdefs to differentiate the MPU from MMU layout will result in a ...'.
>
>> definitions will result in a messy and hard-to-read/maintain code.
>> So move MMU related definitions to a new file, i.e. mmu/layout.h to
>> avoid spreading "#ifdef" everywhere.
>
> AFAICT, you are moving all memory layout definition in a separate file. So I
> would say it explicitely rather than using "MMU related definitions".
>
>> Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
>> Signed-off-by: Penny Zheng <penny.zheng@xxxxxxx>
>> Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>
>
> With the comments addressed:
>
> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
Thanks, I’ve taken this tag with above two comments fixed.
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
