[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 5/8] x86: address MISRA C:2012 Rule 8.4
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 9 Aug 2023 15:48:22 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aiX0nx08s7rsrGTCb7zbmS6NckAEj1pNnvMYg6Sfa+0=; b=WVAJv7nKRNDzSoRMp3SMt34MsnTHaG2RFsxZB0Lm1fOa/4YWwl3wwHI+Pv/4Ptc/kwPcvELc97VwjWGs3B+CPm6mHlhseeuJpAzUSg74wyChl1Tp4psf8Zp7zynaS1IuQoG3sE8+7ArpMEIXliogu8WzGJOAGC0ZSy82/ZFRUVXnZKeY3k2+X60cdx5QFXhxi5TREr/x4wH0iWbyZoc4jHcOzOF+jezy/c7T0QPMGdobnzITVlMTReT3LPQnJrEc0uqNGLwx3Cq70mvFd09ZFUQYUKqJ/Z7o9l0KjAuceHuLW+lubUnWzLuoCZ5U4e0S6xB3V8Ce9I/dd1wz6Z6fPQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qt3jCZT36OvyLyjVbuYqBu1bRoW+ETHahrim5JAfj7b7Ikt1HSVTJMD6FVzWl5zLC2SFLVIzXsngIj+y6PDloC1Hj+ZoBQHVXJk/6vfIwGbIwdxzohaAezDKOYMkgh2sQf5p8YrDgtDICxs7osVysRQWlBoI6HIepRQIS81Yv4uZQN855etPAHTFaOmZFagEMDkUUiSiPh0APZkny1dRG5jWIXH5uAFOzMFCcT9RbhKcYCbH9qtTUGkx7G0qkcHBUJv/xRAowIIOJQxwOlOXjWj2xD2/hIsA2gl4AZ1/fC/v+cHw+SbQ53y5GEEYZu5J2Yh+yDgoICsQwV+5mpZKtg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 09 Aug 2023 13:48:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.08.2023 13:02, Nicola Vetrini wrote:
> The functions and variables touched by this commit can be static,
> as they are only used within the same unit. This in turn addresses
> the absence of declarations that violates Rule 8.4.
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
I'm happy with the code changes here and also in patch 3, but please
make the titles meaningful (in patch 3 the prefix also wants to be
more specific). As mentioned, the Misra rule is secondary here, and
hence doesn't need to be present in the titles.
Jan
|
