[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 6/8] xen/arm: mm: address MISRA C:2012 Rule 8.4
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 9 Aug 2023 13:43:02 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u/Yj8Ae1uxprVYPAiU4vBf3XP8MCk4USbss9Nmn4utc=; b=cdSHLd+wL5Hg9JHPpaWcL+cIfG44GK/hZ1WiylzIUNzaP3u01w37tceYBEvuYfLJs8dCVhf+XLf4MrHxej1Nv2dsj0OqosmCp08fZf6iXEZ42YK2XXlttFPyrjUIblUfjx9XO16cBY/Es/K7QnxNm7iU2mkn86qSwzUdskeq1wFzJ+XMyMDSkJIwFp//33In6l4+u61XRKYD6SVCTZTA7cASqh0GSnicggnNrmRaSKlFpGLdbTIY3ipDBOeBmOIaN0CeT0F/L+rboPG8MIs7LqDJyzGyTLtj0Gj8NlVBcCvoFLWZnHMgWdcDVbX+x/vmV8UQS0n9TkFuiH/SB5kMAQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bhspUFx4EVyOE5wl2kcyP63Fr1ycDh72ZskEqRYcSPj8exdNnXI7ebODNf2Sb7c6S9SGSNCWLnj0DXX8pSGPn7Zo7wB28r7baP/Ul39KgX04J4gf0srjbmVwQlKVcTZ0EMFCwGDRBH79slgI1hJb97dTwQ5v/xf4Z/WcCm7VGJZxTuQTG9CSL6YvjodroqII1iyL3p31j/XtgCVYRRPUHfXkx5I6bHdkIY9Ft71vYUlWbFTRoiatYoI5kw8F2K+VNQVkGP03Ap+OYa3TtK+A1lPVE3h0O3yAOwLq3muMIh180Ko2rFxOiGJSBAIzeQ9dvY2DxT3etNrlNvvUWbUPBQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, "xenia.ragiadakou@xxxxxxx" <xenia.ragiadakou@xxxxxxx>, "ayan.kumar.halder@xxxxxxx" <ayan.kumar.halder@xxxxxxx>, "consulting@xxxxxxxxxxx" <consulting@xxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 09 Aug 2023 13:44:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZyrEdmNcwigzYukmEfRcETstuuK/h+WWA
- Thread-topic: [XEN PATCH 6/8] xen/arm: mm: address MISRA C:2012 Rule 8.4
> On 9 Aug 2023, at 12:02, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx> wrote:
>
> Add a declaration for the variable 'init_ttbr' to resolve
> the violation of Rule 8.4 present in the associated source file 'mm.c'.
>
> No functional changes.
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> ---
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
With:
Fixes: 4557c2292854 ("xen: arm: rewrite start of day page table and cpu bring
up")
If maintainers are ok
> xen/arch/arm/include/asm/mm.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h
> index 5b530f0f40..698e54aff0 100644
> --- a/xen/arch/arm/include/asm/mm.h
> +++ b/xen/arch/arm/include/asm/mm.h
> @@ -165,6 +165,9 @@ struct page_info
> #define _PGC_need_scrub _PGC_allocated
> #define PGC_need_scrub PGC_allocated
>
> +/* Non-boot CPUs use this to find the correct pagetables. */
> +extern uint64_t init_ttbr;
> +
> extern mfn_t directmap_mfn_start, directmap_mfn_end;
> extern vaddr_t directmap_virt_end;
> #ifdef CONFIG_ARM_64
> --
> 2.34.1
>
>
|
