[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 5/5] x86: refactor macros in 'xen-mca.h'
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 8 Aug 2023 14:06:50 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kbSVd4AQ/cg4rWC6Eiz1nBnPOOJ0qhAEOljRQ+KIphM=; b=iWWxYU9cvC3XTEDGpweRMDzKC28vtcsJTGiE6eNm9NJm9/jWyH4aE36Up7cDjIEIezpjQxrsp1djVVvkSJ3mx8YAtNZpBCpR5tCDFUTEJm5noJc1G/5sbAP/71khH22KyqPWDo/Cc2DlZDMv2yEr5u/wLt4d0xYtWhBPR/CaFmjzdOEIFX8figWLuD9iR4wBO64QmFgHW2NDP5rPdnlcJQJegOIZCER55kdN/y7O/3uUGkxhlgUDqLuq1e/Wqh8YqkidTXlJoRK1SNQ/5nLHc9BHJFdiO04TaG8DjDpuFVtps7SPvETNGfn416wEX08+qeu7cNw8ggFGRBBMdjsYAw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CyOM7dJNu0A7qG6HCeasam+Gn4m0TCwhQcapVozyWE6sfjOgUUwKoQgahM0Owsp4l9a5LRecP50tobVYtqAlq8xx2LwtrcAhRzeUoki+UEVFemxAWWL9cwTYD6ZKz4aBYGszqxvWUYuELTHev+3Haq35wLqtVXegZFMrfzxezd6K6EjpiLDOuLUCYvyBzTbBHReiUplwq3f9iizGFhTeoXujiMbs/pORHjuesNyFHxcfP4IfSO81ZY1+xUEeH+riDqXjUz8LDD5ubBX7R3TZ5sRqQ5wnluue5Y3V3l+z+WWtBRIjL88bwhs00IjrEwiJEhLiPACykdL1u2jjwnPP0Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 08 Aug 2023 12:06:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08.08.2023 14:02, Nicola Vetrini wrote:
> On 08/08/2023 13:08, Nicola Vetrini wrote:
>> The macros defined 'xen/include/public/arch-x86/xen-mca.h' are revised
>> to address the following concerns:
>> - needless underscore prefixes for parameter names;
>> - the variable 'i' in function 'mce_action' that is shadowed
>> by the local variable in the macro.
>>
>> Therefore, the refactoring aims to resolve present shadowing
>> issues, which violate MISRA C:2012 Rule 5.3, and lessen the
>> probability of future ones with some renames.
>>
>> No functional change.
>>
>> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
>> ---
>> Changes in v2:
>> - Added missing parentheses.
This ...
>> - Clarified commit message.
>> ---
>
> Missing a
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> from the other version, since nothing changed code-wise.
... isn't exactly "nothing", but well.
Jan
|
