[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] xen/ppc: Switch to medium PIC code model
- To: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 8 Aug 2023 07:59:01 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7m4ctNrmOfO/RfePvyQSK2MCUsiV+pzkfaZdvF5ctkM=; b=F/gADHFb6Cjti7y8cbW5kp66P5h1rxPOdDkD57JMYInY3E7N3vLtlFYM1YHdsEjrkQ6I9dlQpyH1/wvvjF7iDsoBZkte67at5//9XT8lIKRkllAvxaeP3/qBtjQAUp6fNWJgTRcLaM89dWyA57ZgMBzq/sYUOsITFpI+eCUJqFPmpgKq6RZ8bAvxQ/5bFonzKOL1mvtxJ9AWHt7sXCgqd6qTeaSwXdNWA5oanuGhAftJjhoqagKzgE30+nlHc2kA+GIUx4H2UVj3aeLq1KW8tr1A+o5nNVg1CSNmZlfvOo2Xsel3l9n9HwTRreaYqBCNFxj6k5pK8hOcxSuXqFKspQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C29dsAKW34byNOvfiZG6+HMKlZEzQvwnbCHugjRvdZeZ8zTfRnWkt4eMnbAK9RysV4noNPKjTqXBOvkEBq2kmRHbTL4LY2tr5sz9PZlC3ojc2f36a4PJbZUTXBZskcFGKUhaE5YN5X6rRlv2AmunUf5ViwIVKvys+b1GQfoxrCb1A9JL0QzrUT4yn/1QYvXQ45ZjVdl4yloAcD0xu9Bnpu5cnJnyiLbjUn3qRyzWcUc+dFzbNfIqWLJNCn0eny0TdJHACp+l7JC3eW6qcicSoRUOOdMuHUV9Bp6hdGLCL4KaB4/EzWKPEP5QGiQMZNK0QTusat5aPKUythCKzDszUg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 08 Aug 2023 05:59:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07.08.2023 18:22, Shawn Anastasio wrote:
> On 8/2/23 2:16 AM, Jan Beulich wrote:
>> On 02.08.2023 02:11, Shawn Anastasio wrote:
>>> --- a/xen/arch/ppc/include/asm/asm-defns.h
>>> +++ b/xen/arch/ppc/include/asm/asm-defns.h
>>> @@ -16,6 +16,13 @@
>>> lis reg, (val) @h;
>>> \
>>> ori reg, reg, (val) @l;
>>> \
>>>
>>> +/*
>>> + * Load the address of a symbol from the TOC into the specified GPR.
>>> + */
>>> +#define LOAD_REG_ADDR(reg,name)
>>> \
>>> + addis reg,%r2,name@toc@ha;
>>> \
>>> + addi reg,reg,name@toc@l
>>
>> Didn't you indicate you'd add blanks after the commas (also) here?
>>
>>> --- a/xen/arch/ppc/ppc64/head.S
>>> +++ b/xen/arch/ppc/ppc64/head.S
>>> @@ -1,6 +1,7 @@
>>> /* SPDX-License-Identifier: GPL-2.0-or-later */
>>>
>>> #include <asm/asm-defns.h>
>>> +#include <asm/asm-offsets.h>
>>>
>>> .section .text.header, "ax", %progbits
>>>
>>> @@ -11,16 +12,19 @@ ENTRY(start)
>>> FIXUP_ENDIAN
>>>
>>> /* set up the TOC pointer */
>>> - LOAD_IMM32(%r2, .TOC.)
>>> + bcl 20, 31, 1f
>>
>> Hard tab slipped in.
>>
>> I'm happy to take care of both while committing; then:
>> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Thanks, Jan. Just to clarify, are there any outstanding comments that I
> need to address in this series, or are they all able to be handled by
> you during commit?
I intend to take care of the minor changes to the last two patches
during commit. The patch here has gone in already anyway.
Jan
|
