[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH] x86/cpu: Address a violation of MISRA C:2012 Rule 8.3


  • To: Federico Serafini <federico.serafini@xxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 7 Aug 2023 17:26:44 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eM/7S9W+t50LzVxhH4a+l1AKY6Fduweh3gg82cmjdH0=; b=Q3fLu6oUhYR6m/YxabjQ4nYTK5eFuPt4KvEbUzgO8akhJ/YojDPclpHB6jNCnzzBuywq8u1f8BgVxZNhWj7+9J94In7z47AjgAVL32U2OY7LPz+6/qGmM/94O+7izemYOiPB8GVHr9aIC80BAz7Q4h+OeEwh/f0VjT7+s+FY6ZSA0sVgxHl80y7jYonPK6IMozWlFVxspXxVibpfxn6Oq92RJGm7sFDdJdBId7bItBc4jsa93eHb5TkGcDP6jjNYopTk13TDbBsDdwSd6fBLPsdRmM3xCxOp7HSkoX3/dEtgy8v5tOWvq/vl/BjWwcxhdkArM58F5JMeh5THEF93YA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c4Tx4je0EZBLvgL0ogTRMdvtVrAQWqgzkYTnuRaeuGkZyD5DXBXDMysPx1vzdJ4PrGuoIa2ThK1BMeMhKWINvPPdOb6Dzkcbq9U+hoiYiIMQ7QKwelqLyQOApzOV2pcOnb4D4sviUIVOuQgm+GwNFOGqLiMsGTiI2jTU7om2nYgwJBqI4/xI99kiDTAEqDzQun9iG7qhzhbevmU0N5FIbT8wwnWi547tHTZ4mTWUQjsqi/hdSI2tJtmo5JhYQXxTwNsqhPndqI7w0FxPiz6kmyRYpprEapxOzEghjJByAcnm3K9L/aCjFnF3TK0XqWptD8MvTJZdOcketew3Vh05pg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 07 Aug 2023 15:26:54 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 07.08.2023 17:24, Federico Serafini wrote:
> Keep consistency between object declarations to address a violation
> of MISRA C:2012 Rule 8.3 ("All declarations of an object or function
> shall use the same names and type qualifiers").
> 
> No functional change.
> 
> Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>

I think this wants both a Reported-by: and a Fixes: tag. The
description would likely also better not follow the boilerplate you
use elsewhere, but instead describe what has happened and hence why
the further change is wanted.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.