[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] x86: Address violations of MISRA C:2012 and drop bool_t
 
- To: Jan Beulich <jbeulich@xxxxxxxx>
 
- From: Federico Serafini <federico.serafini@xxxxxxxxxxx>
 
- Date: Mon, 7 Aug 2023 11:03:04 +0200
 
- Cc: consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
 
- Delivery-date: Mon, 07 Aug 2023 09:03:08 +0000
 
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
 
 
 
On 07/08/23 10:44, Jan Beulich wrote:
 
On 04.08.2023 16:11, Federico Serafini wrote:
 
Give a name to unnamed parameters to address violations of
MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with
named parameters").
Keep consistency between object and function declarations thus
addressing violations of MISRA C:2012 Rule 8.3 ("All declarations of an
object or function shall use the same names and type qualifiers").
Replace the occurrences of bool_t with bool.
 
Hmm, I read the title as a promise that bool_t would be gone from the
code base (which I couldn't really believe). Perhaps "... by replacing
bool_t uses"?
 
 
Sounds good to me.
--
Federico Serafini, M.Sc.
Software Engineer, BUGSENG (http://bugseng.com)
 
 
    
     |