[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] x86: mechanically rename to address MISRA C:2012 Rule 5.3
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 1 Aug 2023 15:48:00 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YphD5DSyEpD09Z5GHtJ4XjWYPjpu6zR/PRBsmuYun2c=; b=hAIZkJEhpOCF5zMRt/V5dQk4hczHdno2eOq+2aWMZy0b90C+C36nI7foizlGKIFWxrKAfcoabIRRWR1U+iD1FlUa9O3ZJre57LYC1LyK9G21luE3ROyOkIrDbewBbmdttzN+Yu2vyZEVu8o29D2KiZ80tcd+kV7DoA8mME9gccp6XBUufLisMx/yr+CEKQZcFr8n382mT7JbqLSQGzYEb7lagKzJzUO98D/KTpnQ4Zooly7b2khCRc+PYB+1Lm5SB+rh9bYcVwhxCJDe9otaYorllnio9YHjrnQwUxiUa/Co21g3Gx1WBzHMSi+K9QUohYabzsyWhkcJSWvf8luAkA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BM+Ylq7dGahQph/Qj1AQspYBh3eb0ovcRqKNbmCC1TAWJKUfYSGpYglmARowTo5L1YYY0Qk9HuNS3zdQytT807ZiNcSQB9emyGC0PuvGlq0oj7ZvvMtd5+gOw6oguEBPCm0fL/vU2rvscxQmx/kh/lvZrTc9/7HL4+m7i8aNn0dOq0ulvkhOtwUt6fxzJ11UcDvfqYcs+KBKPDZR3H/A2tuyc/Gg39VV5fixQnpaKDae8Y7SHq7E9UYDKzacUHS0biB9uvap9pBhSOfu6GnrNuMoJAe4YpK8REKs4pWIz4H/ICLA0/WjOXgjDN4mz3CJ7alZf5FS18/b01NGSO/uvA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 01 Aug 2023 13:48:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.08.2023 10:58, Nicola Vetrini wrote:
> Rule 5.3 has the following headline:
> "An identifier declared in an inner scope shall not hide an
> identifier declared in an outer scope"
>
> The renames done by this patch avoid shadowing from happening.
> They are as follows:
> - s/socket_info/sock_info/ in 'do_write_psr_msrs'
>
> The parameter 'cpu_khz' that causes a violation in 'pit_init'
> is unused, and hence can be removed.
>
> Parameter 'debug_stack_lines' in 'compat_show_guest_stack' is removed,
> since the shadowed static variable has the same purpose.
>
> The declaration of 'init_e820' is renamed to be consistent with its
> definition.
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> This patch is the non-controversial part of patch 1/4 from series
> https://lore.kernel.org/xen-devel/cover.1690788513.git.nicola.vetrini@xxxxxxxxxxx/
> The other part has been dealt with with a patch from Jan Beulich
> (not yet committed at the time of writing)
> https://lore.kernel.org/xen-devel/e9035197-b329-af2e-65ed-af31cd0375c2@xxxxxxxx/
(Just) naming this v2 (or whichever version would have come next) would
have been nice.
Jan
|
