[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] xenoprof: default to off


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 10 Jul 2023 11:48:09 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9NiTw2ecYw7wSXcIiRXU2ocxqscz82Bs1Osjze34n8w=; b=AWvBLxFhE4KXBaHSXU88r8Q/6nWmECGG9zsDpZHj7iAGWoe5S0vl9hhymSYMp8gIYSCmF8yqtg/v1D189hJqSH/+aU9sINnJR2W5lQFDcQ+jp6PZNjShuJESMvdgkXA8mS0dM/wGJkzZ6N2zlWdej08YWKwk3RwfUqK6GTffDT/WKnVy4AGNpnqtyJSleX93eS6kQE+/tAE+v774mvk6wbCxBfeLaABKw8L/6RGLH30DS2IFfeahq3IqhmZ+lzoE+coObqdjCWSMsOJ/wi0owHwF9dOI+QlTKNy5DmJHMozj7W2F/k9XZoWNiUi1k1WgVEOrDLt2LiDvvyGH/yY/8w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ECjbLPSn/96FMEL1Q1U06RHz22LMKG8phVWjPNplJrMgEuSjUYlpTc5yKsZLQ9MHmDss6+3mDJAqad4F5mha/acDVfqsoacm4OfpIb4UQHwxoG7DywE9KfJIZG49i1fwuUviqUgREfsFP9JpvQQ96PjKmj7eY30KniLF99IT5yt3/vJZpPysy7SE4sbS/hkVSZAz09jtzu8cUh+Vsmi4XzYRiUud7UnFHxOHEXyadbJak36oQ1TNB/gqcrxeU9K6y/oa51d7zPTqHCEeGR9IEmY5yVSaBSNd/xqIhxqc/bJzAlIMArmH7UsJKYC/96BB2KdeAP/j2D16LzDVX36+kQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Mon, 10 Jul 2023 09:48:24 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

This being x86-only right now, and its x86 bits being heavily outdated,
let's no longer enable this by default.

While there also adjust the "help" keyword spelling.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---
The adjustment to pvshim_defconfig of course isn't strictly necessary,
but I think the file would better have overrides for things that need a
non-default setting. (Visible in context, BIGMEM would then probably
also want dropping.) Yet if this causes concerns, I can certainly drop
again this part of the change.

--- a/xen/arch/x86/configs/pvshim_defconfig
+++ b/xen/arch/x86/configs/pvshim_defconfig
@@ -13,7 +13,6 @@ CONFIG_EXPERT=y
 # CONFIG_HYPFS is not set
 # CONFIG_BIGMEM is not set
 # CONFIG_KEXEC is not set
-# CONFIG_XENOPROF is not set
 # CONFIG_XSM is not set
 # CONFIG_UNSUPPORTED is not set
 # CONFIG_SCHED_CREDIT is not set
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -229,10 +229,9 @@ config EFI_SET_VIRTUAL_ADDRESS_MAP
       If unsure, say N.
 
 config XENOPROF
-       def_bool y
-       prompt "Xen Oprofile Support" if EXPERT
+       bool "Xen Oprofile Support" if EXPERT
        depends on X86
-       ---help---
+       help
          Xen OProfile (Xenoprof) is a system-wide profiler for Xen virtual
          machine environments, capable of profiling the Xen virtual machine
          monitor, multiple Linux guest operating systems, and applications



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.