Re: [PATCH 2/2] tools/python: Fix memory leak on error path

[Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Jun 26, 2023 at 08:07:46PM +0200, Marek Marczykowski-Górecki wrote:
> On Thu, Jun 08, 2023 at 02:59:13PM +0100, Luca Fancellu wrote:
> > Commit 56a7aaa16bfe introduced a memory leak on the error path for a
> > Py_BuildValue built object that on some newly introduced error path
> > has not the correct reference count handling, fix that by decrementing
> > the refcount in these path.
> > 
> > Fixes: 56a7aaa16bfe ("tools: add physinfo arch_capabilities handling for 
> > Arm")
> > Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> > Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> Acked-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>

Oh, and BTW, in relation to the discussion on the summit about
committing process, the buggy version was committed without my ack,
after waiting for my review for about two weeks.

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

Attachment: signature.asc
Description: PGP signature