[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v4] xen/include: avoid using a compiler extension for BUILD_BUG_ON_ZERO.
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Sat, 24 Jun 2023 09:32:26 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fotqRkqNoYTuzqU0W1r0ierS+Msh9fLdtl0bqziEVQ4=; b=ofgcu7Rz+kanLdjiq+4z/HD3XeDA3GpDsi9sjOghMPNCOEn8Z58Fjq3ciar2mGVpCO1NzaZj0nRAsO1yH546kIHu/9NdjYUWkttuKAvrWhT3EyaIgSMqJDD7w41RdZnlFktZUJcm5Y75Q9nSVs/afror+W4RJYBUvAzY/Hm8y1TWnl+W2WJJJWgS/QR0cWROa3ENTelbNL02ka05/mGDMC3aY00lm/zZlzgtXEjF71r2k4Oegno7S4TF6HGV5MTzo/yYCKQS+1C47/W4Ddraafb41VzYSf4yeSbWXjYjXxG0fblM5RtziAfnAacIC7v7rvCHBo7HIMWhnMG5EcYl9w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WyyHRo0Ama/pd6PWkaNtomia12J1Mb8wVVvbB06djoJ32c6hJtxjhnMu2oKVLbk47XODyFE32CIIVSTo34FdF55O/e2iZTz8pSGmrvIQVkaomqRWW6pi9KONt+0hLk2CjPD1SRx77SJBIf3oG76l/BHhVk9NOM/anMBAHSrg+KngOhtPdxjaNDmh3gqrdirRVHS9J6W2xK5y16r5NITIAbgRkrffgm6572YurE+iorb108GkwvAy+pz2+9Nx6jkFFBiV6kPO9noggMyZnKCUvRRxa1j39bBtIzKZdMDi8YxG9sjv4hos3AtyIdaxLdosScU1sOEGdzgw3y4awFYOdg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, bertrand.marquis@xxxxxxx, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Delivery-date: Sat, 24 Jun 2023 07:33:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.06.2023 09:11, Julien Grall wrote:
> On 23/06/2023 18:16, Jan Beulich wrote:
>> I'm not happy to, with the continued use of the
>> two U suffixes. It may seem minor, but to me it feels like setting a
>> bad precedent.
>
> I wasn't able to find the reasoning behind your objections in the
> archive. I would like to understand your concern before providing any
> ack. Would you be able to give a pointer?
I appreciate the Misra-invoked desire to add U suffixes where
otherwise (visual) ambiguities may exist. But on numbers like
0 or 1, and when use of e.g. resulting #define-s doesn't require
the constants to be of unsigned type, I view such suffixes purely
as clutter. In the specific case I might go as far as questioning
why, when U is added, L isn't added as well, to "support" the
size_t result aspect also from the "width of type" perspective.
Jan
|
