Re: [PATCH v2 0/3] Early serial on Power

[Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>]

On 6/23/23 1:42 AM, Jan Beulich wrote:
> On 22.06.2023 22:57, Shawn Anastasio wrote:
>> Changes in v2:
>>   - Split main patch into two - one for basic C environment setup and
>>     one for serial
>>   - Mark OpenFirmware functions and early_printk functions as __init and
>>     change boot-of.o to boot-of.init.o in Makefile
>>   - Change <xen/lib.h> include to <xen/stdarg.h> and drop skeleton
>>     headers that are no longer necessary for build as a result
> 
> What is this about? There's no change to non-ppc files here
> according to ...
> 
>>  automation/gitlab-ci/test.yaml           |  20 ++++
>>  automation/scripts/qemu-smoke-ppc64le.sh |  27 +++++
>>  xen/arch/ppc/Kconfig.debug               |   5 +
>>  xen/arch/ppc/Makefile                    |   3 +
>>  xen/arch/ppc/boot-of.c                   | 100 +++++++++++++++++
>>  xen/arch/ppc/configs/ppc64_defconfig     |   1 +
>>  xen/arch/ppc/early_printk.c              |  28 +++++
>>  xen/arch/ppc/include/asm/asm-defns.h     |  53 +++++++++
>>  xen/arch/ppc/include/asm/boot.h          |  23 ++++
>>  xen/arch/ppc/include/asm/byteorder.h     |  12 ++
>>  xen/arch/ppc/include/asm/early_printk.h  |  15 +++
>>  xen/arch/ppc/include/asm/msr.h           |  51 +++++++++
>>  xen/arch/ppc/include/asm/processor.h     | 136 +++++++++++++++++++++++
>>  xen/arch/ppc/include/asm/types.h         |  21 ++++
>>  xen/arch/ppc/ppc64/Makefile              |   1 +
>>  xen/arch/ppc/ppc64/asm-offsets.c         |  55 +++++++++
>>  xen/arch/ppc/ppc64/head.S                |  55 +++++----
>>  xen/arch/ppc/ppc64/of-call.S             |  83 ++++++++++++++
>>  xen/arch/ppc/setup.c                     |  28 +++++
>>  19 files changed, 697 insertions(+), 20 deletions(-)
> 
> ... this. Plus lib.h already includes stdarg.h.

Sorry, that was a bit ambiguous on my part. I meant that I changed

  #include <xen/lib.h>

to

  #include <xen/stdarg.h>

in arch/ppc/boot-of.c to reduce the number of headers
that I needed to create in arch/ppc/include/asm in order for the build
to work. lib.h includes (directly and indirectly) many things from asm/
but stdarg.h is mostly standalone.

> Jan

Thanks,
Shawn