[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [XEN PATCH v2] xen/arm: fix violations of MISRA C:2012 R8.3 on parameter names.
On 23/06/23 09:32, Julien Grall wrote: Hi, On 23/06/2023 07:54, Federico Serafini wrote:To comply with Rule 8.3 ("All declarations of an object or function shall use the same names and type qualifiers") change the parameter names in order to have function declarations consistent with the corresponding definitions. Change the function identifier 'access_guest_memory_by_ipa' to 'access_guest_memory_by_gpa' in accordance with modifications on its formal parameters: 'gpa' is used more frequently than 'ipa' and is therefore preferable.I already hinted in the previous version, but I guess this wasn't clear enough. A patch should do one similar thing because it is easier to review and justify.For instance you explain the renaming function renaming but you don't really say why sometimes you updated the definition but other the declarations.I think this patch should be split in multiple parts:1. Patch to rename arch_guest_memory_by_ipa() and update the parameter name 2. Patch(s) to rename the parameter name on the definitions (e.g. vcpu_vgic_init() & co). They could be bundled by file. 3. Patch to rename the parameter name on the declarations. This is pretty much your patch v1 but without the changes in 1/2.Cheers, Hello, thank you for your suggestions. Regards -- Federico Serafini, M.Sc. Software Engineer, BUGSENG (http://bugseng.com)
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |