[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v2 1/2] tools/console: Add escape argument to configure escape character
On 22/06/2023 15:07, Jan Beulich wrote: On 22.06.2023 15:55, Peter Hoyes wrote:From: Peter Hoyes <Peter.Hoyes@xxxxxxx> Dom0 may be accessed via telnet, meaning the default escape character (which is the same as telnet's) cannot be directly used to exit the console. It would be helpful to make the escape character customizable in such use cases. Add --escape argument to console tool for this purpose. Create parse_escape_character static function to convert a character string (which may include a '^' modifier) into an ANSI integer. Add argument to getopt options, parse escape character and pass value to console_loop. If --escape is not specified, it falls back to the existing behavior using DEFAULT_ESCAPE_SEQUENCE. Signed-off-by: Peter Hoyes <Peter.Hoyes@xxxxxxx> --- tools/console/client/main.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-)Short of a cover letter, replying here: What has changed from v1? This then may or may not explain why Luca's R-b aren't here and in patch 2 (anymore). Jan Luca's R-b are in v3 - the only changes between v1 and v3 are the footers.I'll make sure to include a cover letter and an inline changelog in future versions. Thanks, Peter
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |