[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [XEN PATCH 03/13] xen/x86: fixed violations of MISRA C:2012 Rule 7.2
On Tue, 20 Jun 2023, Simone Ballarin wrote: > From: Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx> > > The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline > states: > "A "u" or "U" suffix shall be applied to all integer constants that are > represented in an unsigned type". > > I propose to use "U" as a suffix to explicitly state when an integer constant > is represented in an unsigned type. > > Signed-off-by: Simone Ballarin <simone.ballarin@xxxxxxxxxxx> Commit message aside: Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx> FYI I would use the following as commit message title to make it unique: xen/x86/hvm/svm: fixed violations of MISRA C:2012 Rule 7.2 > --- > xen/arch/x86/hvm/svm/asid.c | 2 +- > xen/arch/x86/hvm/svm/svm.c | 8 ++++---- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/xen/arch/x86/hvm/svm/asid.c b/xen/arch/x86/hvm/svm/asid.c > index 09f8c23fd9..56306d1a16 100644 > --- a/xen/arch/x86/hvm/svm/asid.c > +++ b/xen/arch/x86/hvm/svm/asid.c > @@ -16,7 +16,7 @@ void svm_asid_init(const struct cpuinfo_x86 *c) > > /* Check for erratum #170, and leave ASIDs disabled if it's present. */ > if ( !cpu_has_amd_erratum(c, AMD_ERRATUM_170) ) > - nasids = cpuid_ebx(0x8000000A); > + nasids = cpuid_ebx(0x8000000AU); > > hvm_asid_init(nasids); > } > diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c > index 59a6e88dff..56cb2f61bb 100644 > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -269,9 +269,9 @@ svm_msrbit(unsigned long *msr_bitmap, uint32_t msr) > */ > if ( msr <= 0x1fff ) > msr_bit = msr_bitmap + 0x0000 / BYTES_PER_LONG; > - else if ( (msr >= 0xc0000000) && (msr <= 0xc0001fff) ) > + else if ( (msr >= 0xc0000000U) && (msr <= 0xc0001fffU) ) > msr_bit = msr_bitmap + 0x0800 / BYTES_PER_LONG; > - else if ( (msr >= 0xc0010000) && (msr <= 0xc0011fff) ) > + else if ( (msr >= 0xc0010000U) && (msr <= 0xc0011fffU) ) > msr_bit = msr_bitmap + 0x1000 / BYTES_PER_LONG; > > return msr_bit; > @@ -2539,8 +2539,8 @@ const struct hvm_function_table * __init start_svm(void) > > setup_vmcb_dump(); > > - if ( boot_cpu_data.extended_cpuid_level >= 0x8000000a ) > - svm_feature_flags = cpuid_edx(0x8000000a); > + if ( boot_cpu_data.extended_cpuid_level >= 0x8000000aU ) > + svm_feature_flags = cpuid_edx(0x8000000aU); > > printk("SVM: Supported advanced features:\n"); > > -- > 2.41.0 >
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |