Xen project Mailing List

Re: [XEN PATCH 00/13] xen: fixed violations of MISRA C:2012 Rule 7.2

To: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>

Date: Tue, 20 Jun 2023 14:13:59 +0200

Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dDkXQFK7prRBYZMb54ImjyAkD1E0Gz1BgEn4V+c9VhY=; b=YZxOi2nqWTcgltg2C2U+MMHOb5gbo7DHld/PHiNrQny0DH7tdnZqdTJw/R65D3YQYlhWTWFy4skTewmipZx8C+Ym6HJj9RSHUBa0LRj3VUGdSjYB7f3WBD8klFR2GhIfXbb0tx1h9XY1PbQbGYtevIpelwlCdZGIaxWUHzxvqvaoQYCnvL6PktvxPGfi1o/M4K4WGjIhzxcjvqhCn4RJsXFo0FBOc69uzu2Z6Jw/Erngm45pqvFidhX0hjQ2pgwpGROQ6ce6TG5LzmHRHVzoB0h+QrqhO7iFauODq85cTySiEjhkEEoe3e7QGKIsdLvOQsEhWrMhjO6KO9XILKTPOQ==

Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fclOfyDEUV4TIFRVgrdOpEoiIhm7fgrjj1GehkynV2976eM9g7QcI2OntOzfFpyi4qMiCUyYhclLMRHyAT01FVDcMzV6PbYaYNMD8WEv1csDY6ghAHzy7wLZhjmtuK9cxI/FwWy3njq77Oqxk9agJpUbodwnSn0oOCUf9CqTMGBV5+dNpXxoadlT1eTGwOcDjL5WRy5OoJLSSjgmZRkhgZUyRoubYJ0PS8n0Pg7f9kFdsbpr8DxASW/ehVHtfLpVDR1Yi6Di8ehCAAuvjVrHj8bg/0lcaCJYWnPPcuX4m//P/cxv6e6vRSB8DPg5qGrMapO8devB30BwsNhLkbEI2Q==

Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;

Cc: consulting@xxxxxxxxxxx, Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Xenia Ragiadakou <Xenia.Ragiadakou@xxxxxxx>, Ayan Kumar <ayan.kumar.halder@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx

Delivery-date: Tue, 20 Jun 2023 12:14:07 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 20.06.2023 12:34, Simone Ballarin wrote: > From: Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx> > > The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline > states: > "A "u" or "U" suffix shall be applied to all integer constants that are > represented in an unsigned type". > > These violations are caused by the missing "u" or "U" suffix in unsigned > integer constants, such as: > > xen/arch/x86/hvm/hypercall.c:132.17-132.26 > if ( (eax & 0x80000000) && is_viridian_domain(currd) ) > > The patches in this series achieve compliance for MISRA C:2012 Rule 7.2 > by adding the "U" suffix to explicitly state when an integer constant is > represented in an unsigned type. > > Some changes are proposed for homogeneity in order to keep the code as > unambiguous as possible. > > > Gianluca Luparini (13): > xen/x86: fixed violations of MISRA C:2012 Rule 7.2 > AMD/IOMMU: fixed violations of MISRA C:2012 Rule 7.2 > xen/x86: fixed violations of MISRA C:2012 Rule 7.2 > xen/arm: fixed violations of MISRA C:2012 Rule 7.2 > xen/common: fixed violations of MISRA C:2012 Rule 7.2 > xen/efi: fixed violations of MISRA C:2012 Rule 7.2 > xen/x86: fixed violations of MISRA C:2012 Rule 7.2 > xen/pci: fixed violations of MISRA C:2012 Rule 7.2 > xen/public: fixed violations of MISRA C:2012 Rule 7.2 > xen/x86: fixed violations of MISRA C:2012 Rule 7.2 > xen/vpci: fixed violations of MISRA C:2012 Rule 7.2 > xen/x86: fixed violations of MISRA C:2012 Rule 7.2 Please can you avoid having four patches with this exact same title? Jan > xen: fixed violations of MISRA C:2012 Rule 7.2 > > xen/arch/arm/domain_build.c | 2 +- > xen/arch/arm/efi/efi-boot.h | 2 +- > xen/arch/arm/gic-v2.c | 6 +- > xen/arch/arm/include/asm/arm64/brk.h | 2 +- > xen/arch/arm/include/asm/arm64/efibind.h | 10 +- > xen/arch/arm/include/asm/arm64/insn.h | 16 +- > xen/arch/arm/include/asm/vreg.h | 2 +- > xen/arch/arm/kernel.c | 2 +- > xen/arch/arm/traps.c | 4 +- > xen/arch/arm/vgic-v2.c | 2 +- > xen/arch/x86/acpi/cpufreq/powernow.c | 14 +- > xen/arch/x86/apic.c | 2 +- > xen/arch/x86/cpu-policy.c | 8 +- > xen/arch/x86/cpu/mcheck/mce-apei.c | 8 +- > xen/arch/x86/cpu/vpmu_intel.c | 4 +- > xen/arch/x86/cpuid.c | 8 +- > xen/arch/x86/efi/efi-boot.h | 6 +- > xen/arch/x86/hvm/hypercall.c | 2 +- > xen/arch/x86/hvm/irq.c | 2 +- > xen/arch/x86/hvm/pmtimer.c | 4 +- > xen/arch/x86/hvm/stdvga.c | 66 +++--- > xen/arch/x86/hvm/svm/asid.c | 2 +- > xen/arch/x86/hvm/svm/svm.c | 8 +- > xen/arch/x86/hvm/viridian/viridian.c | 2 +- > xen/arch/x86/hvm/vlapic.c | 6 +- > xen/arch/x86/hvm/vmx/vmcs.c | 6 +- > xen/arch/x86/hvm/vmx/vvmx.c | 12 +- > xen/arch/x86/include/asm/apicdef.h | 2 +- > xen/arch/x86/include/asm/config.h | 2 +- > xen/arch/x86/include/asm/guest/hyperv-tlfs.h | 28 +-- > xen/arch/x86/include/asm/hpet.h | 2 +- > xen/arch/x86/include/asm/hvm/trace.h | 4 +- > xen/arch/x86/include/asm/hvm/vioapic.h | 2 +- > xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 6 +- > xen/arch/x86/include/asm/hvm/vmx/vmx.h | 32 +-- > xen/arch/x86/include/asm/msi.h | 2 +- > xen/arch/x86/include/asm/msr-index.h | 204 +++++++++---------- > xen/arch/x86/include/asm/pci.h | 8 +- > xen/arch/x86/include/asm/x86-defns.h | 24 +-- > xen/arch/x86/include/asm/x86_64/efibind.h | 10 +- > xen/arch/x86/monitor.c | 6 +- > xen/arch/x86/percpu.c | 2 +- > xen/arch/x86/psr.c | 2 +- > xen/arch/x86/spec_ctrl.c | 8 +- > xen/arch/x86/x86_64/acpi_mmcfg.c | 2 +- > xen/arch/x86/x86_64/pci.c | 2 +- > xen/arch/x86/x86_emulate/x86_emulate.h | 2 +- > xen/common/device_tree.c | 4 +- > xen/common/efi/boot.c | 8 +- > xen/common/efi/runtime.c | 2 +- > xen/common/gunzip.c | 2 +- > xen/common/xmalloc_tlsf.c | 2 +- > xen/drivers/char/ehci-dbgp.c | 4 +- > xen/drivers/passthrough/amd/iommu-defs.h | 122 +++++------ > xen/drivers/passthrough/pci.c | 4 +- > xen/drivers/vpci/msi.c | 2 +- > xen/drivers/vpci/msix.c | 2 +- > xen/drivers/vpci/vpci.c | 6 +- > xen/include/acpi/cpufreq/processor_perf.h | 2 +- > xen/include/efi/efiapi.h | 10 +- > xen/include/efi/efidef.h | 2 +- > xen/include/efi/efiprot.h | 22 +- > xen/include/public/arch-arm/smccc.h | 8 +- > xen/include/public/arch-x86/xen-x86_64.h | 8 +- > xen/include/public/io/ring.h | 10 +- > xen/include/public/memory.h | 2 +- > xen/include/public/sysctl.h | 4 +- > xen/include/xen/bitops.h | 10 +- > xen/include/xen/cper.h | 34 ++-- > xen/include/xen/libfdt/fdt.h | 2 +- > xen/include/xen/libfdt/libfdt.h | 2 +- > xen/lib/muldiv64.c | 2 +- > xen/lib/x86/cpuid.c | 8 +- > xen/lib/x86/policy.c | 2 +- > 74 files changed, 422 insertions(+), 422 deletions(-) >

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.