[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [QEMU PATCH 1/1] virtgpu: do not destroy resources when guest suspend
- To: Gerd Hoffmann <kraxel@xxxxxxxxxx>, Marc-André Lureau <marcandre.lureau@xxxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Tue, 20 Jun 2023 09:11:51 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wXCUPVhwbBhr7s2UxEOh6kI/4cG7oRfsZSMfv7HxOc4=; b=Spb9BvWDjlsxdcNUbvDBcKiw5jNGtFe469ByzWBfZiDf6/eIzkOk5qHV70gzqSUtQcg2MBXCAF3hFNDVprjyWQc2GSjJU0K6YP2UPmWveOKqCiORtR5pFbDohJegys9BqXPzT5J0JX920rvE8b3mIcUxB+SmqeGfT1SL2ETqMpR2RRZAHcnoLMlOtvC9rOZPMqJw/Yq0YA6tpB1IgxUGiWy9p3CNpqSJuqLwh/DXzWS755AWx2/BZCz4SGt0I3goj5/ydQ3X25LJiYagIcJyC/xNWOunNra066TDRkeIwgLNycT1WyznTCs2ua+jB9b5MSiOcpsQx+4DufJ/u16x1Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ExYa8uybhMekXuxiT9f9xIp32qQwvK6w1eSL8k9wwEbx6jjFXkRbpOpwRdaSUBmcAeUDWOVbLH7W6YwpfojBKPRryVAGhNSpoinxTy9CLtiFnzd9NaNylM9sxcYr3rgWjfWnOofj9w5vGfal2WRM9PE3pWpVv+yFNVQB0PNlGUnFPkjq+kUpM/WiaolwWknQN1d0lSzpsufAKgxIesyYmcTY0lYT4fFxYzkho+qNLdRRB0FZ6fTNjRHYntTGqtsSSO35vnPwCEd1FW4xuXfefEUGvg6bjTYTmwQjQdn9BVOWqYfSI6nhXd6t4QEJnOutiss5c5S7bqWfu5V6J/zCbA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Damien Hedde <damien.hedde@xxxxxxxxxxxxx>, "Michael S . Tsirkin" <mst@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Antonio Caggiano <antonio.caggiano@xxxxxxxxxxxxx>, "Dr . David Alan Gilbert" <dgilbert@xxxxxxxxxx>, Robert Beckett <bob.beckett@xxxxxxxxxxxxx>, "qemu-devel@xxxxxxxxxx" <qemu-devel@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Deucher, Alexander" <Alexander.Deucher@xxxxxxx>, "Koenig, Christian" <Christian.Koenig@xxxxxxx>, "Hildebrand, Stewart" <Stewart.Hildebrand@xxxxxxx>, Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, "Huang, Honglei1" <Honglei1.Huang@xxxxxxx>, "Zhang, Julia" <Julia.Zhang@xxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Tue, 20 Jun 2023 09:12:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZmbUjDQZRLEUzRUmYVwd7de4D46+HI2eAgAsCsACAAb/9gA==
- Thread-topic: [QEMU PATCH 1/1] virtgpu: do not destroy resources when guest suspend
Hi Gerd Hoffmann
On 2023/6/19 20:51, Gerd Hoffmann wrote:
> Hi,
>> Adding a new command requires new feature flag (and maybe it should be in
>> the <0x1000 range instead)
>>
>> But I am not sure we need a new message at the virtio-gpu level. Gerd, wdyt?
>>
>> Maybe it's not a good place to reset all GPU resources during QEMU reset()
>> after all, if it's called during s3 and there is no mechanism to restore
>> it. Damien?
>
> The guest driver should be able to restore resources after resume.
Thank you for your suggestion!
As far as I know, resources are created on host side and guest has no backup,
if resources are destroyed, guest can't restore them.
Or do you mean guest driver need to send commands to re-create resources after
resume?
If so, I have some questions. Can guest re-create resources by using
object(virtio_vpu_object) or others? Can the new resources replace the
destroyed resources to continue the suspended display tasks after resume? I
think those will help me improve my implementation, thank you!
>
> take care,
> Gerd
>
--
Best regards,
Jiqian Chen.
|
