[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0.5/2] x86/boot: Clean up early error asm
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 19 Jun 2023 13:43:26 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RLg8KbR3kowrxvsOGbOqXn/Dc6gQZtQTySoi1YJNEWQ=; b=b71S8/UTDlQePcDUtJ8hc2fh+jiRne4Y/WYEhbcbh/Ha6BYdkFrWWiqgi3n9w1QcnoCQhLSFkNoT4jiKdLDOWVkLQvho3PdMRvUU+CPWhqtqIyW3xi2GaVikoBU0qQ6Q7IxFafiQFdubw8oOB0MclV5TePUypsCoPv0IgRgQ5utGufSDIJ+WN2myQH24BfTl4mGjPBJGFS5lBqCMrcmxDxCcG4jcbBWQyIomC86dbDzDhRlfOOspJIlG8lFYwR3DVWdwnIT0tiFB/6gL+P5DSSwYqALYPvwStc6yNf+7sQnZ6wS3IUeC9NBycgffKwNqxNjGX6Mr7ekKVk2Vy9uSsA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WRrPYqvRuKNneBtcfmQMmlLnrznhv9dqfuJraOBiA+jmqRZP3FX8/67b0tIvu1GD2Ce9BUYTp7RVsJtxVAuF35tYeInH4k+vFVFTC9TetVCigFGEIZcT1gM42dz/I1kYPzUDwYrKGi/dyu3x/4z7NqU5Jj50bgBF70w66gCuJuvmtojhlMUnZqeRYc5rIVjJWeAfKWNd98mH87XlU/72uaPSh0FgCwyGHjJNGyef0dPQqY8ad0fGjS9bCcgRRa6U0c4fUqrpkJJYryIqCFRkUH/o8io28CMrr7fTzBLhj2I5YHkk3pP4aWjdy8Uy5tNVZz1GQ+t0aMA7kDZ/VIvW5w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 19 Jun 2023 11:44:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.06.2023 13:20, Andrew Cooper wrote:
> On 19/06/2023 9:10 am, Jan Beulich wrote:
>> On 16.06.2023 20:23, Andrew Cooper wrote:
>>> The asm forming early error handling is a mix of local and non-local
>>> symbols,
>>> and has some pointless comments. Drop the "# Error message" comments,
>>> tweaking the style on modified lines, and make the symbols local.
>>>
>>> However, leave behind one real symbol so this logic disassembles nicely
>>> without merging in to acpi_boot_init(), which is the thing that happens to
>>> be
>>> immediately prior in my build.
>>>
>>> No functional change.
>>>
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Thanks.
>
>> with one request:
>>
>>> --- a/xen/arch/x86/boot/head.S
>>> +++ b/xen/arch/x86/boot/head.S
>>> @@ -142,25 +142,27 @@ efi_platform:
>>>
>>> .section .init.text, "ax", @progbits
>>>
>>> -bad_cpu:
>>> - add $sym_offs(.Lbad_cpu_msg),%esi # Error message
>>> +early_error:
>> This symbol, which isn't really used except by .size/.type below,
>> could do with a comment saying that it's intentionally here despite
>> having no real reference.
>
> Ok. /* Here to make the disassembly better. */ ?
Yes please.
Jan
|
