[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 02/42] mm: Move pte/pmd_mkwrite() callers with no VMA to _novma()
- To: "david@xxxxxxxxxx" <david@xxxxxxxxxx>, "rppt@xxxxxxxxxx" <rppt@xxxxxxxxxx>
- From: "Edgecombe, Rick P" <rick.p.edgecombe@xxxxxxxxx>
- Date: Wed, 14 Jun 2023 17:00:31 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3zaZ0bD6+23kzURnAWK/nc1bI2BfpFbmpV+dupnusbY=; b=KfskkY8joG+1OJJj9ZuP8nQNOYgtd4qDoOMWP7RiQfA3kz2ndndTJFMVvJs4fmeJ1EOZtlLFJPsHmCKKEguk8DYwZvScgrbYm7QD5oTcvFwMuwVSLhOqhTYdaT3aF3ehLUMwrlPfam5xUh875nTnqtl7pc9oAJ/1gv6gtN5o/bfTacKp9EwO75XWgNaic6H9BsX5iiq8CrKnrq4aZ2VQUHwe6mrDjs+nainE5QwgmBFccFfJdNr8lGv+s0Wuif4AfJAKhwW5Bd+r+pL9llTBm8ZV0NgGMBStvNSHY4R7iG8q8FhXFg+nDH0xEk0LSKjuDX6c8RVISKZKV2I9TAVPXQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mYy1NN3n3qFGqVwRWx8bz4hYQ5u581rb2d4mLfsuhJ25i/pazqvU+e/LNriq078LYiEYN323bqT4cUwKsLPqvYUjbs2Fw+QMySncqt+0cKsClIPo5ESiNyKn2w8nq82PJe5pI3wg66hEaQKmivG7CrdzduyzZACSBNEOMJ4E2sN7s+QmDoQBgXR8uWJBPSgJb34w5wV+UfuoKAeQu61xVE4jyA3kJWMI+PysJlIaPMOmOBNQZSQ537NQmu7JlgnjEBzOxUjJW9cVPY+W4eiK5YeMBKUnK0Pds+bfCuIzGQC7Wi0ysl3z8gg8EWYX+NYN3xTTmBmFpwf7bsX87EGqDg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com;
- Cc: "linux-doc@xxxxxxxxxxxxxxx" <linux-doc@xxxxxxxxxxxxxxx>, "tglx@xxxxxxxxxxxxx" <tglx@xxxxxxxxxxxxx>, "kcc@xxxxxxxxxx" <kcc@xxxxxxxxxx>, "linux-arch@xxxxxxxxxxxxxxx" <linux-arch@xxxxxxxxxxxxxxx>, "Lutomirski, Andy" <luto@xxxxxxxxxx>, "nadav.amit@xxxxxxxxx" <nadav.amit@xxxxxxxxx>, "kirill.shutemov@xxxxxxxxxxxxxxx" <kirill.shutemov@xxxxxxxxxxxxxxx>, "szabolcs.nagy@xxxxxxx" <szabolcs.nagy@xxxxxxx>, "Schimpe, Christina" <christina.schimpe@xxxxxxxxx>, "peterz@xxxxxxxxxxxxx" <peterz@xxxxxxxxxxxxx>, "corbet@xxxxxxx" <corbet@xxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "dethoma@xxxxxxxxxxxxx" <dethoma@xxxxxxxxxxxxx>, "broonie@xxxxxxxxxx" <broonie@xxxxxxxxxx>, "linux-s390@xxxxxxxxxxxxxxx" <linux-s390@xxxxxxxxxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, "pavel@xxxxxx" <pavel@xxxxxx>, "bp@xxxxxxxxx" <bp@xxxxxxxxx>, "mike.kravetz@xxxxxxxxxx" <mike.kravetz@xxxxxxxxxx>, "linux-api@xxxxxxxxxxxxxxx" <linux-api@xxxxxxxxxxxxxxx>, "john.allen@xxxxxxx" <john.allen@xxxxxxx>, "jamorris@xxxxxxxxxxxxxxxxxxx" <jamorris@xxxxxxxxxxxxxxxxxxx>, "arnd@xxxxxxxx" <arnd@xxxxxxxx>, "bsingharora@xxxxxxxxx" <bsingharora@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "jannh@xxxxxxxxxx" <jannh@xxxxxxxxxx>, "oleg@xxxxxxxxxx" <oleg@xxxxxxxxxx>, "fweimer@xxxxxxxxxx" <fweimer@xxxxxxxxxx>, "keescook@xxxxxxxxxxxx" <keescook@xxxxxxxxxxxx>, "gorcunov@xxxxxxxxx" <gorcunov@xxxxxxxxx>, "rdunlap@xxxxxxxxxxxxx" <rdunlap@xxxxxxxxxxxxx>, "hpa@xxxxxxxxx" <hpa@xxxxxxxxx>, "mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "hjl.tools@xxxxxxxxx" <hjl.tools@xxxxxxxxx>, "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, "debug@xxxxxxxxxxxx" <debug@xxxxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>, "Syromiatnikov, Eugene" <esyr@xxxxxxxxxx>, "Torvalds, Linus" <torvalds@xxxxxxxxxxxxxxxxxxxx>, "akpm@xxxxxxxxxxxxxxxxxxxx" <akpm@xxxxxxxxxxxxxxxxxxxx>, "dave.hansen@xxxxxxxxxxxxxxx" <dave.hansen@xxxxxxxxxxxxxxx>, "Yang, Weijiang" <weijiang.yang@xxxxxxxxx>, "Eranian, Stephane" <eranian@xxxxxxxxxx>
- Delivery-date: Wed, 14 Jun 2023 17:01:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZnYu5myZdSN5guk62QnYDURPfWq+IWqsAgACP+gCAAAtSgIABkmQA
- Thread-topic: [PATCH v9 02/42] mm: Move pte/pmd_mkwrite() callers with no VMA to _novma()
On Tue, 2023-06-13 at 19:00 +0200, David Hildenbrand wrote:
> On 13.06.23 18:19, Edgecombe, Rick P wrote:
> > On Tue, 2023-06-13 at 10:44 +0300, Mike Rapoport wrote:
> > > > Previous patches have done the first step, so next move the
> > > > callers
> > > > that
> > > > don't have a VMA to pte_mkwrite_novma(). Also do the same for
> > >
> > > I hear x86 maintainers asking to drop "previous patches" ;-)
> > >
> > > Maybe
> > > This is the second step of the conversion that moves the callers
> > > ...
> >
> > Really? I've not heard that. Just a strong aversion to "this
> > patch".
> > I've got feedback to say "previous patches" and not "the last
> > patch" so
> > it doesn't get stale. I guess it could be "previous changes".
>
> Talking about patches make sense when discussing literal patches sent
> to
> the mailing list. In the git log, it's commit, and "future commits"
> or
> "follow-up work".
>
> Yes, we use "patches" all of the time in commit logs, especially when
> we
> include the cover letter in the commit message (as done frequently
> in
> the -mm tree).
I think I'll switch over to talking about "changes". If you talk about
commits it doesn't make as much sense when they are still just patches.
Thanks.
|