Re: [PATCH] xen/evtchn: Purge ERROR_EXIT{,_DOM}()

[Roberto Bagnara <roberto.bagnara@xxxxxxxxxxx>]

On 13/06/23 19:45, Andrew Cooper wrote:
> On 13/06/2023 6:39 pm, Julien Grall wrote:
> > Hi,
> >
> > On 13/06/2023 17:22, Andrew Cooper wrote:
> > > These are disliked specifically by MISRA, but they also interfere
> > > with code
> > Please explicitly name the rule.
> I can't remember it off the top of my head.
>
> Stefano/Bertrand?
Rule 2.1

> > > legibility by hiding control flow.  Expand and drop them.
> > >
> > >    * Rearrange the order of actions to write into rc, then render rc
> > > in the
> > >      gdprintk().
> > >    * Drop redundant "rc = rc" assignments
> > >    * Switch to using %pd for rendering domains
> > >
> > > No functional change.  Resulting binary is identical.
> > >
> > > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
> Thanks.
>
> > > base-commit: f29363922c1b41310c3d87fd9a861ffa9db9204a
> > I notice you have a few e-mail contain this tag. This is a pretty
> > useful when reviewing patches. Do you know which tool is creating it?
> Plain git, and the capability has been around for years and years but
> nigh on impossible to search for or find in the manual.  Searching for
> "base-commit" gets you a tonne of intros of how to rebase.
>
> You want
>
> [format]
>          useAutoBase = "whenAble"
>
> or pass --base=auto to git-format-patch
>
> ~Andrew