[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v1 3/8] xen/riscv: introduce reset_stack() function
On Mon, 2023-06-12 at 09:12 +0200, Jan Beulich wrote: > On 06.06.2023 21:55, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx> > > This wants addressing the "Why?" aspect in the description. Is the > present > code wrong in some perhaps subtle way? Are you meaning to re-use the > code? I am re-using it after switching from 1:1 world to reset a stack. > If so, in which way (which is relevant to determine whether the new > function may actually continue to live in .text.header)? Actually there is no such requirement for reset_stack to live in .text.header. > > --- a/xen/arch/riscv/riscv64/head.S > > +++ b/xen/arch/riscv/riscv64/head.S > > @@ -27,8 +27,14 @@ ENTRY(start) > > add t3, t3, __SIZEOF_POINTER__ > > bltu t3, t4, .L_clear_bss > > > > + jal reset_stack > > + > > + tail start_xen > > + > > +ENTRY(reset_stack) > > la sp, cpu0_boot_stack > > li t0, STACK_SIZE > > add sp, sp, t0 > > > > - tail start_xen > > + ret > > + > ~ Oleksii
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |