[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/5] libxl: drop dead assignments to "ret" from libxl__domain_config_setdefault()

To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
From: Juergen Gross <jgross@xxxxxxxx>
Date: Mon, 12 Jun 2023 14:14:32 +0200
Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Daniel Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 12 Jun 2023 12:14:35 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 12.06.23 13:46, Jan Beulich wrote:

The variable needs to be properly set only on the error paths.

Coverity ID: 1532311
Fixes: ab4440112bec ("xl / libxl: push parsing of SSID and CPU pool ID down to 
libxl")
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>


Reviewed-by: Juergen Gross <jgross@xxxxxxxx>

---
If XSM is disabled, is it really useful to issue the 2nd and 3rd calls
if the 1st yielded ENOSYS?


Probably not.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

References:
- [PATCH 0/5] tools: address Coverity UNUSED issues
  - From: Jan Beulich
- [PATCH 2/5] libxl: drop dead assignments to "ret" from libxl__domain_config_setdefault()
  - From: Jan Beulich

Prev by Date: Re: [PATCH] xen/arm: rename guest_cpuinfo in domain_cpuinfo
Next by Date: Re: [PATCH 3/5] libxg: drop dead assignment to "ptes" from xc_core_arch_map_p2m_list_rw()
Previous by thread: [PATCH 2/5] libxl: drop dead assignments to "ret" from libxl__domain_config_setdefault()
Next by thread: Re: [PATCH 2/5] libxl: drop dead assignments to "ret" from libxl__domain_config_setdefault()
Index(es):
- Date
- Thread

Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.