Re: [PATCH] tools/xenstored: Correct the prototype of domain_max_chk()

[Juergen Gross <jgross@xxxxxxxx>]

On 12.06.23 12:13, Julien Grall wrote:
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Some version of GCC will complain because the prototype and the
> declaration of domain_max_chk() don't match:
>
> xenstored_domain.c:1503:6: error: conflicting types for 'domain_max_chk' due to 
> enum/integer mismatch; have '_Bool(const struct connection *, enum accitem,  
> unsigned int)' [-Werror=enum-int-mismatch]
>   1503 | bool domain_max_chk(const struct connection *conn, enum accitem what,
>        |      ^~~~~~~~~~~~~~
> In file included from xenstored_domain.c:31:
> xenstored_domain.h:146:6: note: previous declaration of 'domain_max_chk' with 
> type '_Bool(const struct connection *, unsigned int,  unsigned int)'
>    146 | bool domain_max_chk(const struct connection *conn, unsigned int what,
>        |      ^~~~~~~~~~~~~~
>
> Update the prototype to match the declaration.
>
> This was spotted by Gitlab CI with the job opensuse-tumbleweed-gcc.
>
> Fixes: 685048441e1c ("tools/xenstore: switch quota management to be table 
> based")
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature