Re: [PATCH 1/4] Rip out simple_strtoll()

[kernel test robot <lkp@xxxxxxxxx>]

Hi Demi,

kernel test robot noticed the following build errors:

[auto build test ERROR on lee-mfd/for-mfd-next]
[also build test ERROR on lee-leds/for-leds-next linus/master v6.4-rc5 
next-20230609]
[cannot apply to xen-tip/linux-next lee-mfd/for-mfd-fixes]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    
https://github.com/intel-lab-lkp/linux/commits/Demi-Marie-Obenour/vsscanf-Return-ERANGE-on-integer-overflow/20230610-110026
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
patch link:    
https://lore.kernel.org/r/20230610025759.1813-1-demi%40invisiblethingslab.com
patch subject: [PATCH 1/4] Rip out simple_strtoll()
config: csky-randconfig-r011-20230610 
(https://download.01.org/0day-ci/archive/20230610/202306101317.YiBrl6OZ-lkp@xxxxxxxxx/config)
compiler: csky-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
        mkdir -p ~/bin
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add lee-mfd 
https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git
        git fetch lee-mfd for-mfd-next
        git checkout lee-mfd/for-mfd-next
        b4 shazam 
https://lore.kernel.org/r/20230610025759.1813-1-demi@xxxxxxxxxxxxxxxxxxxxxx
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross 
W=1 O=build_dir ARCH=csky olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross 
W=1 O=build_dir ARCH=csky SHELL=/bin/bash drivers/md/bcache/

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: 
https://lore.kernel.org/oe-kbuild-all/202306101317.YiBrl6OZ-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   drivers/md/bcache/util.c: In function 'bch_strtoll_h':
>> drivers/md/bcache/util.c:28:18: error: implicit declaration of function 
>> 'simple_strtoll'; did you mean 'simple_strtoull'? 
>> [-Werror=implicit-function-declaration]
      28 |         type i = simple_ ## name(cp, &e, 10);                   \
         |                  ^~~~~~~
   drivers/md/bcache/util.c:82:1: note: in expansion of macro 'STRTO_H'
      82 | STRTO_H(strtoll, long long)
         | ^~~~~~~
   cc1: some warnings being treated as errors


vim +28 drivers/md/bcache/util.c

cafe563591446c Kent Overstreet     2013-03-23  22  
cafe563591446c Kent Overstreet     2013-03-23  23  #define STRTO_H(name, type)  
                                \
169ef1cf6171d3 Kent Overstreet     2013-03-28  24  int bch_ ## name ## _h(const 
char *cp, type *res)            \
cafe563591446c Kent Overstreet     2013-03-23  25  {                            
                                \
cafe563591446c Kent Overstreet     2013-03-23  26       int u = 0;              
                                \
cafe563591446c Kent Overstreet     2013-03-23  27       char *e;                
                                \
cafe563591446c Kent Overstreet     2013-03-23 @28       type i = simple_ ## 
name(cp, &e, 10);                   \
cafe563591446c Kent Overstreet     2013-03-23  29                               
                                \
cafe563591446c Kent Overstreet     2013-03-23  30       switch (tolower(*e)) {  
                                \
cafe563591446c Kent Overstreet     2013-03-23  31       default:                
                                \
cafe563591446c Kent Overstreet     2013-03-23  32               return -EINVAL; 
                                \
cafe563591446c Kent Overstreet     2013-03-23  33       case 'y':               
                                \
cafe563591446c Kent Overstreet     2013-03-23  34       case 'z':               
                                \
cafe563591446c Kent Overstreet     2013-03-23  35               u++;            
                                \
df561f6688fef7 Gustavo A. R. Silva 2020-08-23  36               fallthrough;    
                                \
cafe563591446c Kent Overstreet     2013-03-23  37       case 'e':               
                                \
cafe563591446c Kent Overstreet     2013-03-23  38               u++;            
                                \
df561f6688fef7 Gustavo A. R. Silva 2020-08-23  39               fallthrough;    
                                \
cafe563591446c Kent Overstreet     2013-03-23  40       case 'p':               
                                \
cafe563591446c Kent Overstreet     2013-03-23  41               u++;            
                                \
df561f6688fef7 Gustavo A. R. Silva 2020-08-23  42               fallthrough;    
                                \
cafe563591446c Kent Overstreet     2013-03-23  43       case 't':               
                                \
cafe563591446c Kent Overstreet     2013-03-23  44               u++;            
                                \
df561f6688fef7 Gustavo A. R. Silva 2020-08-23  45               fallthrough;    
                                \
cafe563591446c Kent Overstreet     2013-03-23  46       case 'g':               
                                \
cafe563591446c Kent Overstreet     2013-03-23  47               u++;            
                                \
df561f6688fef7 Gustavo A. R. Silva 2020-08-23  48               fallthrough;    
                                \
cafe563591446c Kent Overstreet     2013-03-23  49       case 'm':               
                                \
cafe563591446c Kent Overstreet     2013-03-23  50               u++;            
                                \
df561f6688fef7 Gustavo A. R. Silva 2020-08-23  51               fallthrough;    
                                \
cafe563591446c Kent Overstreet     2013-03-23  52       case 'k':               
                                \
cafe563591446c Kent Overstreet     2013-03-23  53               u++;            
                                \
cafe563591446c Kent Overstreet     2013-03-23  54               if (e++ == cp)  
                                \
cafe563591446c Kent Overstreet     2013-03-23  55                       return 
-EINVAL;                         \
df561f6688fef7 Gustavo A. R. Silva 2020-08-23  56               fallthrough;    
                                \
cafe563591446c Kent Overstreet     2013-03-23  57       case '\n':              
                                \
cafe563591446c Kent Overstreet     2013-03-23  58       case '\0':              
                                \
cafe563591446c Kent Overstreet     2013-03-23  59               if (*e == '\n') 
                                \
cafe563591446c Kent Overstreet     2013-03-23  60                       e++;    
                                \
cafe563591446c Kent Overstreet     2013-03-23  61       }                       
                                \
cafe563591446c Kent Overstreet     2013-03-23  62                               
                                \
cafe563591446c Kent Overstreet     2013-03-23  63       if (*e)                 
                                \
cafe563591446c Kent Overstreet     2013-03-23  64               return -EINVAL; 
                                \
cafe563591446c Kent Overstreet     2013-03-23  65                               
                                \
cafe563591446c Kent Overstreet     2013-03-23  66       while (u--) {           
                                \
cafe563591446c Kent Overstreet     2013-03-23  67               if ((type) ~0 > 
0 &&                            \
cafe563591446c Kent Overstreet     2013-03-23  68                   (type) ~0 / 
1024 <= i)                      \
cafe563591446c Kent Overstreet     2013-03-23  69                       return 
-EINVAL;                         \
cafe563591446c Kent Overstreet     2013-03-23  70               if ((i > 0 && 
ANYSINT_MAX(type) / 1024 < i) ||  \
cafe563591446c Kent Overstreet     2013-03-23  71                   (i < 0 && 
-ANYSINT_MAX(type) / 1024 > i))   \
cafe563591446c Kent Overstreet     2013-03-23  72                       return 
-EINVAL;                         \
cafe563591446c Kent Overstreet     2013-03-23  73               i *= 1024;      
                                \
cafe563591446c Kent Overstreet     2013-03-23  74       }                       
                                \
cafe563591446c Kent Overstreet     2013-03-23  75                               
                                \
cafe563591446c Kent Overstreet     2013-03-23  76       *res = i;               
                                \
cafe563591446c Kent Overstreet     2013-03-23  77       return 0;               
                                \
cafe563591446c Kent Overstreet     2013-03-23  78  }                            
                                \
cafe563591446c Kent Overstreet     2013-03-23  79  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki