Re: [PATCH] tools/ocaml/xc: Fix xc_physinfo() bindings

[Christian Lindig <christian.lindig@xxxxxxxxx>]

> On 9 Jun 2023, at 10:37, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx> wrote:
> 
> On 09/06/2023 9:17 am, Christian Lindig wrote:
>>> On 8 Jun 2023, at 20:33, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx> wrote:
>>> 
>>> +type arm_physinfo_caps =
>>> +  {
>>> +    sve_vl: int;
>>> +  }
>>> +
>> 
>> Does the OCaml side need to know about the structure of this value or is it 
>> enough to pass it around as an abstract value because all logic is on the C 
>> side? I assume the OCaml side needs at least a way to persist the value and 
>> hence needs to know some representation.
> 
> Yes, Ocaml does need to know about the structure.
> 
> [..]
> 
> The vector length is a multiple of 128.  This value is more amenable to
> being understood in a log file by a human.


Acked-by: Christian Lindig <christian.lindig@xxxxxxxxx>