Re: [PATCH v2] xen/arm: un-break build with clang

[Julien Grall <julien@xxxxxxx>]

Hi,

On 25/05/2023 20:15, Stewart Hildebrand wrote:
> clang doesn't like extern with __attribute__((__used__)):
>
>    ./arch/arm/include/asm/setup.h:171:8: error: 'used' attribute ignored 
> [-Werror,-Wignored-attributes]
>    extern DEFINE_BOOT_PAGE_TABLE(boot_pgtable);
>           ^
>    ./arch/arm/include/asm/lpae.h:273:29: note: expanded from macro 
> 'DEFINE_BOOT_PAGE_TABLE'
>    lpae_t __aligned(PAGE_SIZE) __section(".data.page_aligned")                  
>  \
>                                ^
>    ./include/xen/compiler.h:71:27: note: expanded from macro '__section'
>    #define __section(s)      __used __attribute__((__section__(s)))
>                              ^
>    ./include/xen/compiler.h:104:39: note: expanded from macro '__used'
>    #define __used         __attribute__((__used__))
>                                          ^
>
> Simplify the declarations by getting rid of the macro (and thus the
> __aligned/__section/__used attributes) in the header. No functional change
> intended as the macro/attributes are present in the respective definitions in
> xen/arch/arm/mm.c.
>
> Fixes: 1c78d76b67e1 ("xen/arm64: mm: Introduce helpers to prepare/enable/disable the 
> identity mapping")
> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall