[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH RFC v2] vPCI: account for hidden devices


  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 26 May 2023 08:45:00 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J23g29un1LOhO77WgR3rIOzyGYtTUUL25Pkp0eBhcyw=; b=MmQ5d2vQqlQ4dtYOAk4xn5IeyKUGe9wsPh3dZvBS8o6kCUJMhYIEBhR4dSgKteL37bZLHtcPZNUkoVVqGAUeWYMHfAg3JhOVz3VNUXY7YxWEXIqMu+ipVwimiLNwgm22T3+sHMqkoJnjjSZDW7qJemDabzLd0cUGx0cmLLPiq+nB8rZJnO4o85fBIpRPQ0492JWHrP4jh59IYV5qlM+yC2NgArLmPNnBMddkwpkQKlXfLOg3kdp4LOTIaH6HXShl2EoWAGxXgiYdEWV2w7iPIQO04m4/BVtuIByCK9UN6fnbdREAJRHPRxwwv/RebqudlqSrX7JK9jgUOgQzJWAZKA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f8bKQCDHSqG25La4LCF1AKrZP77iAC1h5VZbY0/J5Ei29Xt6fUUCjhGlJjY03MNOYNLTxUmF454BxAWgS5//KKGqcDqEAKXfRcVkq+p9P0u4D7/rozuQ8qsUF1hO/e0Dc//3gQoO1EPioJ3u5xPyNnEZEINdDpt/fNgwfLLVbOKIcvcjjdVRirtcW9K12rRfc9NzRWClA2fKlmAw41jR0JyUiqIg2UYc2J8S9hOmmJo+nu3jGLwXfRvB0oCiSmR2SheGTOa00eu4sNCy/9wK7pkoYZCWSiKjTDzHVinSBk363mBgmCZoC4WWpR9ozN2LB+5qDh0Dd0G0LgJiaqDGKQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 26 May 2023 06:45:23 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 25.05.2023 21:32, Stefano Stabellini wrote:
> Like I wrote, personally I am happy with whatever gets us to have the PVH
> test in gitlab-ci faster.
> 
> However, on the specific problem of PCI devices used by Xen and how to
> deal with them for Dom0 PVH, I think they should be completely hidden.
> Hidden in the sense that they don't appear on the Dom0 PCI bus. If the
> hidden device is a function of a multi-function PCI device, then the
> entire multi-function PCI device should be hidden.
> 
> I don't think this case is very important because devices used by Xen
> are timers, IOMMUs, UARTs,

... USB debug ports (EHCI, XHCI), ...

> all devices that typically are not multi-function,

except for the ones added. Furthermore see video_endboot() for a case
of also hiding the VGA device, which isn't unlikely to have secondary
functions (sound controllers are not uncommon). Hence ...

> so it is OK to be extra careful and remove the entire
> device from Dom0 in the odd case that the device is both multi-function
> and only partially used by Xen. This is what I would do for Xen on ARM
> too.

... at best I would see this as a non-default mode of operation. Of
course we could also play more funny games with vPCI, like surfacing
a "stub" device in place of a hidden one, so the other functions can
still be found.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.