[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 13/15] build: fix compile.h compiler version command line
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 25 May 2023 14:50:02 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EUrh6mM0e6631BB3xw5QIAo8gpsPFec7oLGrtfQnYfU=; b=HZz1wPDze80WQNEGORDFAm5NP7D1V4ALg1nSyP7eVEgnyokR+ibPqXWFJRFvU41n0pLk79kFv8SNSIQ7UhGlAeIIYahOSz3OS+u3Wdlyuh4IH22FyPm9KKmkBaSCw11z1lc13cN2KruBuQAP9SP3nwyDva0LoNSievg1kMN3LCYcStLbvfi5UDmK73DRp87pGpqbASD2UkdsBvTfwOsaQ7PAlhbNAK0yr4OBHRK84WJz/+wyWbT6eT++HKfIM6K0u2QWbPzWlheGsSCvV1DAO3lOD51v1zRjjg//uT5VE9QotgFHSXbhlFsoFZeBZea98dwIdKGoFUSEY0MebhZCsg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CtITCzKaIiJJFak2vVHIbwQybhzvpGF/X/kFgP0YdvzBbho+mkt1GwTHiiCJXOQ/jFXbdy4wsZMed5KcBMsmqolov7BDwLB8DBoqC1HGo4ZyBUXM11nmH/Kfki6cOPMwAN4cT2gdFnmADBMmpz9nWncj6P1+avcx4ObFmr/w+B7NpW+yG4F0B0+nlI9XM1zXelfgKPYlVBJ1xikCGDzwyJMby6GPm94Kc1ESL+Zv/5ZXjI59iEI8rIW1Bqgx5p20CpYN87kckaZMq20a46kTgvakC25QNRClgNjNYsVGI7By4ZvdmQ9Gf85cdpcZcwmMNX2SvpOk6TvtH8+oyvdZlQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Delivery-date: Thu, 25 May 2023 12:50:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.05.2023 11:43, Luca Fancellu wrote:
>
>
>> On 23 May 2023, at 17:38, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>>
>> CFLAGS is just from Config.mk, instead use the flags used to build
>> Xen.
>>
>> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>> ---
>>
>> Notes:
>> I don't know if CFLAGS is even useful there, just --version without the
>> flags might produce the same result.
>>
>> xen/build.mk | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/build.mk b/xen/build.mk
>> index e2a78aa806..d468bb6e26 100644
>> --- a/xen/build.mk
>> +++ b/xen/build.mk
>> @@ -23,7 +23,7 @@ define cmd_compile.h
>> -e 's/@@whoami@@/$(XEN_WHOAMI)/g' \
>> -e 's/@@domain@@/$(XEN_DOMAIN)/g' \
>> -e 's/@@hostname@@/$(XEN_BUILD_HOST)/g' \
>> - -e 's!@@compiler@@!$(shell $(CC) $(CFLAGS) --version 2>&1 | head -1)!g'
>> \
>> + -e 's!@@compiler@@!$(shell $(CC) $(XEN_CFLAGS) --version 2>&1 | head
>> -1)!g' \
>> -e 's/@@version@@/$(XEN_VERSION)/g' \
>> -e 's/@@subversion@@/$(XEN_SUBVERSION)/g' \
>> -e 's/@@extraversion@@/$(XEN_EXTRAVERSION)/g' \
>> --
>> Anthony PERARD
>>
>>
>
> Yes I think Andrew is right, so I guess $(XEN_CFLAGS) can be dropped?
>
> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>
> I’ve tested this patch with and without the $(XEN_CFLAGS), so if you drop it
> you can
> retain my r-by if you want.
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
preferably with the $(CFLAGS) dropped, which again I'd be happy to do
while committing.
Jan
|
