[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 11/15] build: rename CFLAGS to XEN_CFLAGS in xen/Makefile
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 25 May 2023 14:28:45 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y6xkpF3UdqhiGgHXn/x/bWlWeO+PYGhF6H4b6VKbcO4=; b=J/ZAdoNrxVTTKFOhSOEvpwIiDwpq0zPWTnu/nkBDn7IKeLyr2PigxDaZI5wJX4ru5mkTp+88m7cIYkkee5CBgutRmYZLdB/z658Yjna2bQdf9BvAwlqPTxir+SkoXq3aaKwDDDYA4i00Umeh0SFty3FxHpIgbsnX8vIrAyoF0qKUXUAm9dGDjdKj/TpY1o6IJ+4/qqbrZEusnQKPeIhTCZ40NLfI9hjoEt9CGYTDzEwyS2/bgx9vu8e+0ntCo/D+GCJwhkl6hOBEBMYifplipskMfah0ZV3m7wWQtSOvQBfQOnRTborl51BWYCi1tJc9GJ8WeaT7Ai32L5tZFfHKVw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GUs3IaAk/BVTsfBldSaYOO5Ac0vIrHJwRPpzxfv3S3JTGw5wr2ExfkDbSFoG8KE1YC7E3EAPVrV48X5yOpft7pIjUgBT8/fyU4j58ZTAyhdW5O9awSUkMWDwBd0xVpQFp/lKt5JKLWVmlG6m5O0oB0hheJgSv1ifRdZzRu5Mdbvwx7Y7Kqy37cEQIbhzWbfOKMZrIDLtTuH1bE7xdbZUzRVf7KXdfLVyrE4BfCdA/RYo7EtHeGr/b135Mp6E0oAR3wiaOP/ua1GlGu+cSwGWNj6svkW4BMqo+g5JO68TCZnUVAoS0hz2A5F/m51aYGESMmBj8S1NVagos/9WMFXNAA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 25 May 2023 12:29:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.05.2023 18:38, Anthony PERARD wrote:
> This is a preparatory patch. A future patch will not even use
> $(CFLAGS) to seed $(XEN_CFLAGS).
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
I have a question though, albeit not directly related to this patch:
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -259,6 +259,7 @@ export KBUILD_DEFCONFIG := $(ARCH)_defconfig
> export XEN_TREEWIDE_CFLAGS := $(CFLAGS)
>
> XEN_AFLAGS =
> +XEN_CFLAGS = $(CFLAGS)
>
> # CLANG_FLAGS needs to be calculated before calling Kconfig
> ifneq ($(shell $(CC) --version 2>&1 | head -n 1 | grep clang),)
> @@ -284,7 +285,7 @@ CLANG_FLAGS += $(call or,$(t1),$(t2),$(t3))
> endif
>
> CLANG_FLAGS += -Werror=unknown-warning-option
> -CFLAGS += $(CLANG_FLAGS)
> +XEN_CFLAGS += $(CLANG_FLAGS)
> export CLANG_FLAGS
> endif
>
> @@ -293,7 +294,7 @@ ifeq ($(call ld-ver-build-id,$(LD)),n)
> XEN_LDFLAGS_BUILD_ID :=
> XEN_HAS_BUILD_ID := n
> else
> -CFLAGS += -DBUILD_ID
> +XEN_CFLAGS += -DBUILD_ID
> XEN_TREEWIDE_CFLAGS += -DBUILD_ID
Is this redundancy necessary? IOW can't XEN_CFLAGS, at an appopriate
place, simply have $(XEN_TREEWIDE_CFLAGS) appended?
Apart from this the same process question again: Is this independent
of earlier patches (except the immediately preceding one), and could
hence - provided arch maintainer acks arrive - go in ahead of time?
Jan
|
