[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] xen/misra: xen-analysis.py: use the relative path from the ...
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Fri, 19 May 2023 07:12:33 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zACNNrTEZFcme8uOsvJd1/loasiAK/ZPNOiFKwUi3dA=; b=LOkhaSeSqgOLN78KUM7XfbKpzdYvt++QwMzHPnB7OcOeuOPvFUVvfFCDvbzh/N2OLiNl7NFB0jKPSnQxuGyHDY1wuXVzpe5w5wzoNkmleBm/uj4MHzCcQauCAbqiwxMp+KUGetVYhJ7mL94AJoyCqsJXpjaJGFKwu2i2ruakbZQRflhQ1EXjVBKLyxkL3pCWAkjaRXfPkfddnUlsuMdIU6qfhURGkEpMSluW80PPT2ctAPo/CXJ1Jej13jpBpvsRSGJpDYbOBW0Tcdr0dWMzGDJuypuRzNpv3DsAFRSpYO2nnfeY+DUaWpQX/FXf21/eqGRXrpEnJhQD1Q0i8qbOcA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OdDyO8K2m0k5SwPhDZVO7PGzDMJoSnl2i+QFip+G2sTilhIt/IuAuunNNnaGu+0vhf/sEivK/5NncpNAaiG9FmqJmDjnFwQPSYmXoZZNNkh03IkZL6M52ZJ1An1BSNg/TKGDU+RZmDv5/PZXpe1+mIK9G1p5XvX1K67w6KpRl7LirHnzQX8N3DSvIahQ3RYcIBOm1FjiH21JZUWBaxr2neTA8kDL9ku5IdKqgSKa8ZLzM3qz5s2gw5n+kWmf9lHweALJ7+6y80GHLKKl0HRdZFllgDbWb4f0etDiRClTsPN0V4Q0Y6/w44BEdWnFDfO2dqo9dxUOPrT1z6PS0558+A==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 19 May 2023 07:13:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZfooyuAY6OgOAbESkC2BSWxnO0K9dtEiAgAOQFACAAAETgA==
- Thread-topic: [PATCH 3/3] xen/misra: xen-analysis.py: use the relative path from the ...
> On 19 May 2023, at 08:08, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> Hi Luca,
>
> On 17/05/2023 02:44, Stefano Stabellini wrote:
>>
>>
>> On Thu, 4 May 2023, Luca Fancellu wrote:
>>> repository in the reports
>>>
>>> Currently the cppcheck report entries shows the relative file path
>>> from the /xen folder of the repository instead of the base folder.
>>> In order to ease the checks, for example, when looking a git diff
>>> output and the report, use the repository folder as base.
>>>
>>> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>>
>> Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>> Tested-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>
> I know this patch is now committed but there is something confusing here.
> At the moment, in the cppcheck report we have paths relative to xen/ e.g.:
> arch/arm/arm64/lib/bitops.c(117,1):...
>
> So after this patch, I would expect to see the path relative to root of
> repository e.g.:
> *xen/*arch/arm/arm64/lib/bitops.c(117,1):...
>
> However, with or without this patch the behavior is the same.
> Did I misunderstand your patch?
Hi Michal,
Thank you for having spotted this, during my tests I was using Xen-analysis.py
so that it
calls the makefile with out-of-tree build, I’ve found after your mail that when
it calls the makefile
with in-tree-build, cppcheck is run from /xen/xen and it causes it to produce
relative path from
there in the TXT fragments, showing the issue you observed.
I have ready a fix for that and I’ll push that soon.
>
> ~Michal
|
