[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 6/8] pci/arm: don't do iommu call for phantom functions
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Thu, 18 May 2023 17:05:40 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wygi/9UjCLj36Lrc8DeTiXmlBt2FEHRZaM65Iiuxq6M=; b=E1PGpbWO6yyskAAiffKgFkZohaHBI9N8+VbuP6f+FSUOA3g4I4MT1DGcbjkhEYMEbXD5Q9Q8sobW4+CBuPt5w9A2TTij34jFPPu2zs+DOI+IsdjxYAvKqR7EXGoH83fQRLx9PAxPYv1EYKceVBkZybh+QUIfv2Qg2kQNdzVhZZBK7T/rXnOH5drTU+2hwVjcU01R1I23bnrRB0lvpNn+hmiJsdJUOh+7y91Y1imoiW7xBmifotRNb4Zb+jANxA2Fzf2lSbFI8OQfNtLZMxSb+hdExCF6wqAFQf2ZIGkVu3lqM4bCdUwYo6ZnY8tIQLnZp4m4a5wofPvKVLnvWX3gqg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gSBMC7Fgg24ZPnpX3aVmBY2/IGVjjGIis5L7Vh1dr0WlP8EJTUwyXTbO5Dh5nsqNJHwN6HLsmeoJ30exuWeo9m9yxBhyuzjg7U6Hko5oV9IM/n2WvlHa5JRtuWrN+TnehPutvBqp38MhD5c5/lZNOtaVCX8JB9cPzoWwx31Blbmsnp/3Rdk0tGcJ34r3xujLThjDmF0IVbt8b9C5EDE46tU3ohO6/0JS06pfp4GPkFqWiSLOB6MUQuqg8O0P9NpFctzNN0pu4qCowJd2+hW31DXwvh3dcEc1EqTEsS7I6niao9ztjr94D0nRcd3zUlGQuz5mB1Q7mh/HkMvK2nvtqQ==
- Cc: Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Bertrand Marquis" <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 18 May 2023 21:06:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 5/12/23 03:28, Jan Beulich wrote:
> On 11.05.2023 21:16, Stewart Hildebrand wrote:
>> It's not necessary to add/remove/assign/deassign pci phantom functions
>> for the ARM SMMU drivers. All associated AXI stream IDs are added during
>> the iommu call for the base PCI device/function.
>>
>> However, the ARM SMMU drivers can cope with the extra/unnecessary calls just
>> fine, so this patch is RFC as it's not strictly required.
>
> Tying the skipping to IS_ENABLED(CONFIG_HAS_DEVICE_TREE) goes against
> one of Julien's earlier comments, towards DT and ACPI wanting to
> co-exist at some point. So I think keeping the supposedly unnecessary
> calls is going to be unavoidable, unless you have a runtime property
> that you could check instead.
I'll drop this patch in v3
|
