[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] x86/vtx: Remove opencoded MSR_ARCH_CAPS check
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 17 May 2023 16:38:51 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CDYEZTAhs+K6wtbgMMY1tDeB20mU/i2j/518ttZD/Ek=; b=Bt0UEUwqxT8tlTLW7jszcEhlYz1Y16QIvTUvj0cJSjNqpED3HVIbN35pm3ivWDU/a4LlZD+aEHJnyWXcJ+lEaLCAWdoHQJWL8Fid6+nXWLK6XRT/3j/z2rFfDzGfUfuTdHqFdDfd0ptMU+SMI+jMsopFZuq7kotswUNxRYY+e+Zf6BKaFgyIVD+8Ig9ghUjIGL4y+T4DpwiSDXgZT7zRCioyoTsPI9nYiTOD9lFVpt/VBsHzaGmS6HTpfxXI4+GI6jiVYj/3jBNhvjQaIEHNYMVUs/ELT6Gk0itdOxFjWzU8RiZY88F1tXzssMxL7l6QfAmJipMZHGD/tT4cg3qUYQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tq1b8VZeZRe6B71MxNbXTpdBDR1wyvVLCpVQYeZ9c7K2JEcXn6UUh5v370SMy9d5lEpggqovYeoeSFY3x5BOfHJ1eSMjWxlPFHLO3VgraWUqDayom2Bgl68g1pie/Sij3sLG6hPkg1Wue/igVWvRhoCCtdMr55slzOd+pTm0ow9ZUaKG1Il8b9Lx+hwILLbnSNlzshZtCJ7kBDPy/hiV08RYrxd0nA2m6g439p/NSb9738OjgmOyv948+yct3OVnv1o2FRFQWri5F1QKJfbRiL7r1PCILsb77gD69BjKk7kPv47ENmwj5NBaYtBOxs4fYbHZmYGHkMh/gpZoIJA3MQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 17 May 2023 14:38:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.05.2023 16:36, Jan Beulich wrote:
> On 16.05.2023 16:53, Andrew Cooper wrote:
>> MSR_ARCH_CAPS data is now included in featureset information.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Oops - this was really meant to be
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
> albeit, like in one of the patches in the earlier series, ...
>
>> --- a/xen/arch/x86/include/asm/cpufeature.h
>> +++ b/xen/arch/x86/include/asm/cpufeature.h
>> @@ -183,6 +183,9 @@ static inline bool boot_cpu_has(unsigned int feat)
>> #define cpu_has_avx_vnni_int8 boot_cpu_has(X86_FEATURE_AVX_VNNI_INT8)
>> #define cpu_has_avx_ne_convert boot_cpu_has(X86_FEATURE_AVX_NE_CONVERT)
>>
>> +/* MSR_ARCH_CAPS 10A */
>> +#define cpu_has_if_pschange_mc_no
>> boot_cpu_has(X86_FEATURE_IF_PSCHANGE_MC_NO)
>
> ... I'm not convinced that having the (unadorned) MSR index here
> is really helpful. In particular to people not knowing the indexes
> by heart (possibly most except you) the number may actually look
> odd / misplaced there.
>
> Jan
>
|
