[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] tools: drop bogus and obsolete ptyfuncs.m4
- To: Olaf Hering <olaf@xxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Tue, 16 May 2023 17:28:34 +0100
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Tue, 16 May 2023 16:28:55 +0000
- Ironport-data: A9a23:jPNdCagAfAbqyOj545dUcI0CX161SxAKZh0ujC45NGQN5FlHY01je htvXzzQa/qMZjD1fYp/Od+w9U4AusTVyYJkT1A6riowECMb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWj0N8klgZmP6sT4QaAzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQxeDUCcjCunt6S+46ncPEwwe0JDtfCadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJYw1MYH49tL7Aan3XejtEqFWTtOwv7nLa1gBZ27nxKtvFPNeNQK25m27B/ jOYozugWExy2Nq39muor0i0h7D0uS7GVthDGo2hxOczqQjGroAUIEJPDgbqyRWjsWa5X9tRA 0UZ4iQqoO4++SSDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJhZebPQ2uclwQiYlv neLkMnuHidHq6CORDSW8bL8hTqqNDIcN2MqeS4ORgxD6N7myLzflTqWEIwlSvTsyISoR3epm WviQDUCa6s7pJ4O2Lmb0En7pwmQuqLREkkczCfJdzfwhu9mX7KNa4ut4FndyP9PKoeFU1WM1 EQ5d9iiAPMmVs/UynHUKAkZNPTwvqvebmWA6bJ6N8N5nwlB7UJPamy5DNtWAE5yevgJdjbyC KM4kVMAvcQDVJdGgEIeXm5QNyjI5fK4fTgGfqqOBjarXnSWXFHvwc2WTRTMt10BaWB1+U3FB b+VcNy3EVERArl9wTy9So81iOF7mnlhmD2CHMyklXxLNIZyg1bEIYrpzXPUNrxphE96iF+9H ylj2zuilEwEDbyWjtj/+o8PN1EaRUUG6WTNg5UPLIare1M2cFzN/teNmdvNjaQ5xfUK/goJl 1nhMnJlJK3X3CaXeFnSNSsyNNsCn/9X9BoGAMDlBn7ws1BLXGplxP53m0cfFVX/yNFe8A==
- Ironport-hdrordr: A9a23:VqipeKMj0QzZ5cBcTsGjsMiBIKoaSvp037BL7TEWdfUxSKalfq +V7ZYmPHzP6Ar5OktQ/OxoUZPoKRi8yXcf2/h0AV7NZniAhIJqFu1fBEnZrgEI1xeQygeV78 ldmw4SMqySMWRH
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, May 12, 2023 at 12:26:14PM +0000, Olaf Hering wrote:
> According to openpty(3) it is required to include <pty.h> to get the
> prototypes for openpty() and login_tty(). But this is not what the
> function AX_CHECK_PTYFUNCS actually does. It makes no attempt to include
> the required header.
>
> The two source files which call openpty() and login_tty() already contain
> the conditionals to include the required header.
>
> Remove the bogus m4 file to fix build with clang, which complains about
> calls to undeclared functions.
>
> Remove usage of INCLUDE_LIBUTIL_H in libxl_bootloader.c, it is already
> covered by inclusion of libxl_osdep.h.
>
> Remove usage of PTYFUNCS_LIBS in libxl/Makefile, it is already covered
> by UTIL_LIBS from config/StdGNU.mk.
>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Obviously, the committer will have to run ./autogen.sh before
committing.
Thanks,
--
Anthony PERARD
|
