[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Logic error in rsa_private


  • To: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, Quan Xu <quan.xu0@xxxxxxxxx>
  • From: Olaf Hering <olaf@xxxxxxxxx>
  • Date: Tue, 16 May 2023 15:54:26 +0000
  • Arc-authentication-results: i=1; strato.com; arc=none; dkim=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1684252476; s=strato-dkim-0002; d=strato.com; h=Message-ID:Subject:Cc:To:From:Date:Cc:Date:From:Subject:Sender; bh=JxzkjrfeFJlPVFGk3GTJIOA37rhi6lspjNY6Lrptp6A=; b=eqeJfH5n1V0Algy0BqA82KEMWMb470omoSziscPRF0y3WH1BZ2mpqB85hZEKcREr+8 T685zqDO1DWkafKA5eY0eOnNtiMUZW3Y/58eS/U7BOBeR7FyT33LO3i3n+31MQWIFdhQ u1yL7U1rjbOkuEGPEG/v1khdSSHVg6YGID8lfFpnZAC643GOmGiIHx/w68GkNtDlXx+v RSaN1Sw7WIX0m+0uQ5EmMgNbkeBlEGXi7MEUp/+rwkFAa0FEBsEbI/QTgwfe2N0IIoEK PLfbNAGIaC7tAVl7R/TqUA3zf5lnzNpyqvpK9EGMQq4MHib3B6BrZ6z47YRfLGBqSG4E ZHIw==
  • Arc-seal: i=1; a=rsa-sha256; t=1684252476; cv=none; d=strato.com; s=strato-dkim-0002; b=lI2xPAg9Ynv20VCu4X3byhGh7Ihu8goWUL2BFNRtu+3THRVi4dM4TwY+9hfLl+1+Fj Z+WlSy2xa9Uj6VKHpH3Xm2doKXYuyOese9hbJsK92vRKlKHrXdsgxe67TOIme0GvN2r4 Yz30d/vOy46QUxB6EGAEnafaTbeysDxsWzEIiVoGIQr6rZyKzgYA9YCwn/6VN8HK9wFV nMU8z7bOuTWOnZnYfUWo+UEfGVh5ESrAOigl3Q9CWwzo2/RL2R3mSIPflPGeYPuKzHHc ym+Z4yL6eUiim/AwOUSXAq+R3WE0jHFsBHzDGiE0aItsFbqxneCObwjqkW7klb+ApnL+ Szig==
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 16 May 2023 15:55:04 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hello,

as shown in 'build.log' at
https://gitlab.com/xen-project/xen/-/jobs/4284741850/artifacts/browse
there is a logic error spotted by gcc 13.

crypto/rsa.c: In function 'rsa_private':
crypto/rsa.c:56:7: error: the comparison will always evaluate as 'true' for the 
address of 'p' will never be NUL
   56 |   if (!key->p || !key->q || !key->u) {

None of p/q/u are pointers. Please have a look at some point.

Thanks,
Olaf

Attachment: pgpHmkLrcNmET.pgp
Description: Digitale Signatur von OpenPGP


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.