[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 13/21] hw/xen: do not set is_external=true on evtchn fds
- To: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Tue, 16 May 2023 15:25:09 +0100
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <qemu-devel@xxxxxxxxxx>, Ronnie Sahlberg <ronniesahlberg@xxxxxxxxx>, Aarushi Mehta <mehta.aaru20@xxxxxxxxx>, <qemu-block@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Peter Lieven <pl@xxxxxxx>, Stefan Weil <sw@xxxxxxxxxxx>, Xie Yongji <xieyongji@xxxxxxxxxxxxx>, Kevin Wolf <kwolf@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Leonardo Bras <leobras@xxxxxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, Hanna Reitz <hreitz@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, David Woodhouse <dwmw2@xxxxxxxxxxxxx>, Coiby Xu <Coiby.Xu@xxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, Stefano Garzarella <sgarzare@xxxxxxxxxx>, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, Daniel P. Berrangé <berrange@xxxxxxxxxx>, Julia Suvorova <jusual@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <eesposit@xxxxxxxxxx>, Juan Quintela <quintela@xxxxxxxxxx>, "Richard W.M. Jones" <rjones@xxxxxxxxxx>, Fam Zheng <fam@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>
- Delivery-date: Tue, 16 May 2023 14:25:42 +0000
- Ironport-data: A9a23:WUeaxazOHDDjFqrAnGB6t+fkwCrEfRIJ4+MujC+fZmUNrF6WrkVSx mMbC2mAO/ePY2GmKtlzPt7i9x4D7JKAyodrSgptqSAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UIHUMja4mtC5QRjPK4T5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KVtW8 aQDJSJUV0C8he+U6umpTbVVnMt2eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKZOUYn1lQ/UfrSmM+hgGX/dDtJ7kqYv6Mt70DYzRBr0airO93QEjCPbZwNwRfI+ judpAwVBDkTL/CG8Xm70UijqeHuohjlYpMxFuGno6sCbFq7mTVIVUx+uUGAieKlh0C3XdJWA 1YZ9ionse4580nDZtf0WjW1vWaEuRhaXddMe8Ug6gaLx7H8+QuVBmEYCDVGbbQOrdI3QyAn0 lahhd7lBTVz9raSTBq1+7qPtTSpODQ9N2IOZSYYCwAC5rHLsIw1yx7CUNtnOKq0lcHuXyH9x SiQqyozjKlVitQEv4254EvaijaEvJXFTgcpoA7QWwqN5A5jfoejaIGA81XX7f9cao2eSzGpp HgFn82SxOQPC5iXk2qKWuplNKqm7uyXOSfRqURiE5ko63Km/HvLVY1c/ThkKEBBMs8Oejjyf AnVtB85zLRUPXG7K59qS420AsUui6PnELzNWu/RcYBmY55/bgaL8ShiI0mK0AjFikknkaglN dGbfMCgAGwBDqJPyDuwTv0al7gxyUgWwGrJTp3/iR2/37eabneITJ8KNVKPaqYy66bsiB7O7 99VOs+OyhNeeO7zeC/a9cgUN19iBWA2GZ3su+RNe+KDKxYgE2YkY9fVzLQrYYV+t75YmufB4 je2XUow4F/kmVXdJAmKY2wlY7TqNb5np3U9Ly0qPH6y1nQjaJrp56AaH7M0Yr4j+sR5wPJ0R uVDcMKFatxfSznW/DISb5jVpp1+eRiigwmDeSGiZVAXZIFIWAHI/tnpYhmp+CRmJjKzncg3p qXm2g6zaYIKWgBKHMvQLvW1wDuZpHUYhad4W0zDIfFVf0Pj9pUsLDb+5tcyLsEQIFPKzyGHj V6+DhIRpO2LqIgwmPHTgqaCroqyGut6FEdAEEHU6L+3MW/R+W/L6ZZNVfvNcT3DWWfc/qKka uNIifbmP5UvnExHspZuO6xmwaI3+53koLoy5g18EW/CdViDFrJqKX7A1s5K3pCh3ZcA51HwA BjWvIAHZ/PQYpiN/EMtyBQNVPyHjeoZiGDrvcs3LWfQvz1woIOdXhAHV/WTsxB1ILxwOYIj5 O4uvs8K9gCy4iYX3sa6YjN8rDrVcCFZO0kzntRDWdKw1FJ3or1XScaEYhIa9q1jfDml3qMCB jaPzJTPiL1HrqYpWypiTCOdtQaxaHlnhfyr8LPgDw7R8jYmrqVttPG0zdjQZlo98/m/+7gvU lWHzmUsTUl0wx9mhdJYQ0enEBxbCRuS9yTZkgVZyDSGEhf5DzCSdgXR3NphG2hIm1+wgxABp O3IoIobeWyCkD7NMtsaBhc+9q2LoS1Z/QzegsG3d/m4820BSWO92MeGPDNYwyYL9Ott3CUrU 8E2prcvAUA6XAZMy5AG536yi+RPFUDYezUZKRyjlYtQdVzhlPiJ8WDmAyiMlgllfpQmLWfQ5 xRSG/9y
- Ironport-hdrordr: A9a23:oCFmuKHvnrN7vG7mpLqELMeALOsnbusQ8zAXPiBKJCC9E/bo8v xG+c5w6faaslkssR0b9+xoW5PwI080l6QU3WB5B97LMDUO0FHCEGgI1/qA/9SPIUzDHu4279 YbT0B9YueAcGSTW6zBkXWF+9VL+qj5zEix792uq0uE1WtRGtldBwESMHf9LmRGADNoKLAeD5 Sm6s9Ot1ObCA8qhpTSPAhiYwDbzee77a7bXQ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, May 04, 2023 at 03:53:19PM -0400, Stefan Hajnoczi wrote:
> is_external=true suspends fd handlers between aio_disable_external() and
> aio_enable_external(). The block layer's drain operation uses this
> mechanism to prevent new I/O from sneaking in between
> bdrv_drained_begin() and bdrv_drained_end().
>
> The previous commit converted the xen-block device to use BlockDevOps
> .drained_begin/end() callbacks. It no longer relies on is_external=true
> so it is safe to pass is_external=false.
>
> This is part of ongoing work to remove the aio_disable_external() API.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Thanks,
--
Anthony PERARD
|
