[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] iommu/amd-vi: fix assert comparing boolean to enum
- To: xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Date: Thu, 11 May 2023 16:51:52 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WRLwXEHiNJLX7HjBGmjUrTtwbY+2Ehv3zGsT/ef0u38=; b=JBOLkziKLkcHIL7+C+VR+UoYx154PTCBRzjDjVTFqpC2HPCcGgpWDKVLk8bV8V76kV/NJA7p3diAV36k53392Sb8IcqbfGQYT3sGAR5okRQd813z5G9cfdjP/+ieFkvnjl/UsurYDe422++Q8gpceEn20Il//cwevFZEZ079YYOyUbn9mdS3dGVke9XIcvZj2zJ1NCy9mq/ri7se6Zn3ZYyAt8QE1MGoPh75Hk0hqIo2gOOTqN0W3f15PKv2GwuXRIJa84oIbvLKmiJJnAPMHtnSHr9X0lqSCIr6uYOuYLG9NuU9HsAsiDY1w98bVdSJZ08APe9OLuo71w/rkw+YbA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P5ShBfjRckqM7hncQynaown3a/AGEa4SUaOQsc3cI+ROz1Bn04AR4/whp7WvlGFcfLuDJTBCnphcda2R4g1NicMrFE0KIYDjVSfbvMvR4jZV4xdWh9qrBxz7DPlWj8qPgz9ciKn5kTFojT96Gbg/LQhcIE8lRxUNcezMOB0hNDurCRs7un/9Z8L5M7i/rxK4VDG2iEXRYj5oLxE/NA8VbSYJ9XVQnd2Faenh1FxI2z8MnX4GjDGnSrFoEjSUxuvwkYCYMDVwysD91sM4LCqneyBeXhUoLuYbyOcxecJHCjs913s92JXvcDBflx6lfXTzjRFpcXv0MtXMqpkLU6Wd/g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Thu, 11 May 2023 14:52:24 +0000
- Ironport-data: A9a23:57LXn67nPOrMn+/HDJUN5AxRtCrGchMFZxGqfqrLsTDasY5as4F+v jZLCm/Va/+PNDGhfoxxOt7noEwO7Zbdm9A2HAdp+HtgHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+7ZwehBtC5gZlPa0S5QeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m5 d4YFyktdy66rO+k/r2Vb8hUioMCI5y+VG8fkikIITDxK98DGMqGaYOaoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OkUooj+GF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8eWxXOmBtJNT+fQGvhCsWWeyU0KWUYsD1ai/un+j3WDAs5RE hlBksYphe1onKCxdfHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQN4sudIyRDcq/ kSUhN6vDjtq2IB5UlqY/7aQ6Dm0aS4cKDZYYTdeFFRcpd7+vIs0kxTDCM55F7K4hcH0Hje2x C2WqC85hPMYistjO7iHwG0rSgmE/vDhJjPZLC2ONo55xmuVvLKYWrE=
- Ironport-hdrordr: A9a23:ymn2carRAhBC/DBwAB+11J0aV5oReYIsimQD101hICG9Ffb1qy nOppsmPHrP4wr5N0tPpTntAsi9qBHnhPxICPgqXYtKNTOO0AHEEGgI1/qA/9SPIVyYysdtkY tmbqhiGJnRIDFB/KDHCdCDYrMdKQ+8gcSVuds=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Or else when iommu_intremap is set to iommu_intremap_full the assert
triggers.
Fixes: 1ba66a870eba ('AMD/IOMMU: without XT, x2APIC needs to be forced into
physical mode')
Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
xen/drivers/passthrough/amd/pci_amd_iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c
b/xen/drivers/passthrough/amd/pci_amd_iommu.c
index 4ba8e764b22f..94e37755064b 100644
--- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
+++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
@@ -240,7 +240,7 @@ static int __must_check amd_iommu_setup_domain_device(
*/
if ( dte->it_root )
ASSERT(dte->int_ctl == IOMMU_DEV_TABLE_INT_CONTROL_TRANSLATED);
- ASSERT(dte->iv == iommu_intremap);
+ ASSERT(dte->iv == !!iommu_intremap);
ASSERT(dte->ex == ivrs_dev->dte_allow_exclusion);
ASSERT(dte->sys_mgt == MASK_EXTR(ivrs_dev->device_flags,
ACPI_IVHD_SYSTEM_MGMT));
--
2.40.0
|
