[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] tools: drop bogus and obsolete ptyfuncs.m4
- To: Olaf Hering <olaf@xxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Tue, 9 May 2023 17:47:33 +0100
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 09 May 2023 16:48:14 +0000
- Ironport-data: A9a23:ArTh6aJLd15VoWIwFE+Rx5UlxSXFcZb7ZxGr2PjKsXjdYENS1T0Gx 2QXW2iCP/aKM2rxe492ao+y8EgG6JWDztJlTwNlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPSwP9TlK6q4mhA4wRvPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4tBHBCp PExcgkJRSCzrtKJkei2cthz05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TTHJ0FwRvC+ DKuE2LRLgErJoaE2xu/8H+GoeDjmnjASdg9C+jtnhJtqALKnTFCYPEMbnO8pfC3okezQ9xbJ goY90IGvaU0sUCmUNT5dxm5u2Kf+A4RXcJKFO834x3LzbDbiy6GAkAUQzgHb8Yp3Oc/XTEw3 0WFt8/oDzdo9raSTBqgGqy89G3of3JPdClbOHFCFFFeizX+nG0tpkjKX9oyHYfvt9neKQHZ8 w/b9iUGtqpG2KbnyJ6H1VzAhjutoL3AQQg0+hjbUwqZ0+9pWGK2T9f2sAaGtJ6sOK7cFwDc5 yZcx6By+chUVfmweDqxrPLh9V1Dz9KMK3XijFFmBPHNHBz9qif4Lei8DNyTTXqF0/romxezO Cc/WisLvve/2UeXgVdfOd7ZNijT5fGI+S7Zfv7VdMFSRZN6aRWK+ipjDWbJgTC2zRd1wP9gZ MfLGSpJMUv29Iw9lGbmLwvj+eVDKt8CKZP7GsmgkkXPPUu2b3+JU7YVWGazghQCxPrc+m39q o8PX/ZmPj0DCIUSlAGLq99MRb3LRFBnba3LRzt/LbHbe1U6RDl4VJc8A9oJIuRYokicrc+Ql lnVZ6OS4ACXaaHvQelSVk1eVQ==
- Ironport-hdrordr: A9a23:gzMUWayNziQEcQXCgc6dKrPwKL1zdoMgy1knxilNoH1uA6qlfq WV9sjzuiWE7wr5J0tApTntAtjkfZqkz/JICOoqU4tKPjOIhILAFugLgLcKpQeQeBEWntQ36U 4KSdkdNDSfNykfsS43iDPZL+od
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, May 02, 2023 at 08:48:00PM +0000, Olaf Hering wrote:
> According to openpty(3) it is required to include <pty.h> to get the
> prototypes for openpty() and login_tty(). But this is not what the
> function AX_CHECK_PTYFUNCS actually does. It makes no attempt to include
> the required header.
>
> The two source files which call openpty() and login_tty() already contain
> the conditionals to include the required header.
>
> Remove the bogus m4 file to fix build with clang, which complains about
> calls to undeclared functions.
>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
That change isn't enough. And I'm not convinced that it needs to be
removed.
First, AX_CHECK_PTYFUNCS is still called in "tools/configure.ac".
Then, AX_CHECK_PTYFUNCS define INCLUDE_LIBUTIL_H and PTYFUNCS_LIBS.
Those two are still used in the tree.
Also, that that macro isn't just about the header, but also about the
needed library.
Thanks,
--
Anthony PERARD
|
