[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] Fix install.sh for systemd
- To: Olaf Hering <olaf@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 9 May 2023 13:47:11 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Rrt8osdwbVzW+5B6L7lGqi/dGheX57n61YDc+SVC4xU=; b=Fr1XP4mvtXLOR8Br1UO1wdn2LsMpguUOokKIJo1kUWPGp4yOrAHBtt9hkO8untzQcuEXCAEOxN4u07PWFoxqRjUoVi8gX+1o9z6BPUmTA8OjiLFORbbz40JKOlSb5SnMGMBIofDB4cDyxmk8ATMa5pHzeoQDMQZUIVKWnosqxAxPyaQnA2xzmbosl/AOG/xIGHoE1GnRagPboQvPblcprmPrpJtLfV1kmZELxzZnKQeJdo4EfHUnU4H8W+XvQcJw1ljUjvZzOewM0jXYoLYiASExQSxewNDJ6a2IVt487KHTHEkpSeJ5qdX7Leg/FaQtzh3oSExrN6mtjX2rhXfteg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VXODCYkUa0V1PDCahs8rEguJm+eZMCePeZ+Qcoa4vR3K1kUHLnEg0MRXXnLE+BvN+ZbHmq0D3oq/GW0mYlaC5Tl2sDl3xpMQ3rFjCNg0AZITRQoIMcyI89Dpl+N42G/4QaX2Br/GN+6b40A5gS6fFCA0EEwtCqqGh7dosYqICM9NeCZct78vCDaZWAlVJF9ebDD1CafkJuMdzt1wdvIqp72kn1SXsUHA/1HLBy2UmJJmnxTa4X79A07gntO0f418PcG4e+jtEtckLv0bxLQ7I2SgMSk0/kYwjiFoqHHvseyqGDytJuAez0SmsiXXHss2Hz57mJHafifIdk/gDbCatw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jason Andryuk <jandryuk@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Tue, 09 May 2023 12:47:39 +0000
- Ironport-data: A9a23:hPtvparieGBD/L2l0FUf24D2M89eBmIkZBIvgKrLsJaIsI4StFCzt garIBmPM6zeYzD0KN1xOo7i9BwB757Ux9MyTAprpXtnQSsT85uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WJwUmAWP6gR5weDzyhNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAD4xMzSsnNmu+6uqZsRL2MklF9K3MpxK7xmMzRmBZRonabbqZvyToPV+jHI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeiraYSEEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXhrqEz3AXMmzB75Bs+f2GE//uhrhKHcd9TM EU/pCBzn4w0+xn+JjX6d1jiyJKehTYbX9NeO+Q38A+Jx+zY7m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+WpDW+IzkILkcNYCYFSU0O5NyLiJ43pgLCSJBkCqHdszHuMTT5w jTPpi5ugbwW1JcPz//iowGBhC+wrJ/USAJz/h/QQm+u8gJ+YsiiepCs7l/Yq/1HKe51U2W8g ZTNoODGhMhmMH1HvHXlrDkldF1x28u4DQ==
- Ironport-hdrordr: A9a23:AP+3g6O1lFGo1MBcTnqjsMiBIKoaSvp037Dk7SFMoHtuA6qlfq GV7ZMmPHrP4gr5N0tMpTntAsW9qDbnhP1ICWd4B8bfYOCkghrUEGlahbGSvAEIYheOiNK1t5 0BT0EOMqyVMbEgt7eC3ODQKb9Jq+VvsprY59s2qU0DcegAUdAE0+4WMGim+2RNNXh7LKt8Op qAx9ZN4wGtcW4Qaa2AdwM4dtmGid3XtY7sJSULDR4/6AWIkFqTmcXHOind8BcCci9FhYwv+2 jdkwD/++GKvvyhxgXHvlWjn6h+qZ/OysZjGMfJsMQTJzn24zzYHLhcZw==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08/05/2023 6:14 pm, Olaf Hering wrote:
> On a fedora system, if you run `sudo sh install.sh` you break your
> system. The installation clobbers /var/run, a symlink to /run. A
> subsequent boot fails when /var/run and /run are different since
> accesses through /var/run can't find items that now only exist in /run
> and vice-versa.
>
> Skip populating /var/run/xen during make install.
> The directory is already created by some scripts. Adjust all remaining
> scripts to create XEN_RUN_DIR at runtime.
>
> XEN_RUN_STORED is covered by XEN_RUN_DIR because xenstored is usually
> started afterwards.
>
> Reported-by: Jason Andryuk <jandryuk@xxxxxxxxx>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
TBH, I think this goes to show how many people do `make install` by hand
on a system, rather than using a packaged version.
One query...
> diff --git a/tools/hotplug/Linux/init.d/xendriverdomain.in
> b/tools/hotplug/Linux/init.d/xendriverdomain.in
> index c63060f62a..1055d0b942 100644
> --- a/tools/hotplug/Linux/init.d/xendriverdomain.in
> +++ b/tools/hotplug/Linux/init.d/xendriverdomain.in
> @@ -49,6 +49,7 @@ fi
>
> do_start () {
> echo Starting xl devd...
> + mkdir -m700 -p @XEN_RUN_DIR@
Why is this 700, and the others just using regular perms?
Also, doesn't it want quoting like the other examples too?
~Andrew
|
