[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 09/12] tools: add physinfo arch_capabilities handling for Arm
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Fri, 5 May 2023 16:56:44 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jB/0Hk7/nAxsOggP+UuejWY5jFRViXw4KZif78sQ5yI=; b=kUsV96PDFHVrz33ERXm5sfeKVfQlq7hFumGUPO+toN7rW37gil8xkBbgm5NdGTZu6HERCyJGD9VnFN7vnzCPiZXwAnehJS285Ni4rhShPj81ObCX0ey71s5dauR4fxabwfPp9gs8YZD+RoWAKd322PQWKWUC7+GYG+QzxdWmJhG2usE6TJbmRtLhh/ULD89uWkJLXJlqpQ7ko+r5nLbmrix8G2iH4yoWSdobW0/cRAn6to9qn5qz4yfH4byutXurJNcemrqD3FKzGJFqF8+INpsi+ICGAj+NjT8H/0yuUpJJZRGiJYqIf3fQkZ9DzEkeEE8ASpi2xDUvpaTXs6izzA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F8p38Tk3nM7Zplfgsp92r0saq6ivKtnz29cXENpOslN41qnvomKrHNwK8rLJyuBAHS5gft8hkui8r06UaqlaGQsTov7s+dpCVu3KS4gEgbibvXNOsHYQfasTdva3cVTKWM43LY591sj1/lSBTLkWIAFZcaWZqdJt8v5IXAUJOR7HLtLBZjEzcPuMEbXBDIZpfR57elfXO0gQcVrDBW904H7N+89YYZAhXLggGK7r9+bAQSd3dkxbGXYN8dOvdvQnjyjTo2N88+1VRYlHbOgnyh9GzIUnfZlLrMvP6T0OazLJmjtQBSkTBIsHpToOXEWMXApORZIwhxu7/YpIcl5FJw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Nick Rosbrook <rosbrookn@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxx>
- Delivery-date: Fri, 05 May 2023 16:57:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZdnKCeDO91wnv7UqBsQsgLvHj6a9HNTmAgAEfoACAA6ADgIAAA1aA
- Thread-topic: [PATCH v6 09/12] tools: add physinfo arch_capabilities handling for Arm
> On 5 May 2023, at 17:44, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>
> On Wed, May 03, 2023 at 09:23:19AM +0000, Luca Fancellu wrote:
>>
>>
>>> On 2 May 2023, at 17:13, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>>>
>>> On Mon, Apr 24, 2023 at 07:02:45AM +0100, Luca Fancellu wrote:
>>>> diff --git a/tools/include/xen-tools/arm-arch-capabilities.h
>>>> b/tools/include/xen-tools/arm-arch-capabilities.h
>>>> new file mode 100644
>>>> index 000000000000..ac44c8b14344
>>>> --- /dev/null
>>>> +++ b/tools/include/xen-tools/arm-arch-capabilities.h
>>>> @@ -0,0 +1,28 @@
>>>> +/* SPDX-License-Identifier: GPL-2.0 */
>>>
>>> Do you mean GPL-2.0-only ?
>>>
>>> GPL-2.0 is deprecated by the SPDX project.
>>>
>>> https://spdx.org/licenses/GPL-2.0.html
>>>
>>>
>>> Besides that, patch looks fine:
>>> Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>>
>> Thanks, I’ll fix in the next push and I’ll add your R-by
>
> Actually, could you use LGPL-2.1-only instead. As this code is to be
> included in libxl, and libxl is supposed to be LGPL-2.1-only, it might
> be better to be on the safe side and use LGPL for this new file.
>
> As I understand (from recent discussion about libacpi, and a quick search
> only), mixing GPL and LGPL code might mean the result is GPL. So just to
> be on the safe side, have this file been LGPL might be better. And it
> seems that it would still be fine to include that file in GPL projects.
>
> Would that be ok with you?
Yes sure, I will use LGPL-2.1-only instead, no problems
>
> Cheers,
>
> --
> Anthony PERARD
|
