Re: [PATCH v3 05/14 RESEND] xenpm: Change get-cpufreq-para output for internal

[Jason Andryuk <jandryuk@xxxxxxxxx>]

On Fri, May 5, 2023 at 3:04 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
> >>> @@ -720,10 +721,15 @@ static void print_cpufreq_para(int cpuid, struct 
> >>> xc_get_cpufreq_para *p_cpufreq)
> >>>          printf(" %d", p_cpufreq->affected_cpus[i]);
> >>>      printf("\n");
> >>>
> >>> -    printf("cpuinfo frequency    : max [%u] min [%u] cur [%u]\n",
> >>> -           p_cpufreq->cpuinfo_max_freq,
> >>> -           p_cpufreq->cpuinfo_min_freq,
> >>> -           p_cpufreq->cpuinfo_cur_freq);
> >>> +    if ( internal )
> >>> +        printf("cpuinfo frequency    : base [%u] turbo [%u]\n",
> >>> +               p_cpufreq->cpuinfo_min_freq,
> >>> +               p_cpufreq->cpuinfo_max_freq);
> >>
> >> ... calling it "turbo" (and not "max") here.
> >
> > I'm fine with "max".  I think I went with turbo since it's a value you
> > cannot sustain but can only hit in short bursts.
>
> ... I don't mind you sticking to "turbo" as long as the description makes
> clear why that was chosen despite the SDM not naming it this way.

I switched to "max" since as you point out that matches the SDM naming.

Regards,
Jason